aws-events: Cannot grant `putEvents` to Service Principals

moelasmar commented 2 months ago

Original issue by @arcrank on 2022-09-16T15:44:27Z

Describe the bug

When trying to grantPutEventsTo an AWS SP, there is a no-op, and no warnings or errors. I would expect if we added a grant to a iam.ServicePrincipal that the underlying grant/policy would be created. We can add an SP to the event bus in the console. Tracing back code I myself didn't necessary find a place where this would have failed, or I would have expected if this was not possible to give a failure message.

Expected Behavior

I would expect the template to have grant policies attached. If for some reason you weren't allowed to add SPs, I would expect a failure message and error.

Current Behavior

Nothing is logged to the terminal when synthing the template snippet is

 "Resources": {
  "bus707364D1": {
   "Type": "AWS::Events::EventBus",
   "Properties": {
    "Name": "MyCustomEventBus"
   },
   "Metadata": {
    "aws:cdk:path": "xxx/bus/Resource"
   }
  },
  "busMyArchiveF1010141": {
   "Type": "AWS::Events::Archive",
   "Properties": {
    "SourceArn": {
     "Fn::GetAtt": [
      "bus707364D1",
      "Arn"
     ]
    },
    "ArchiveName": "MyCustomEventBusArchive",
    "Description": "MyCustomerEventBus Archive",
    "EventPattern": {
     "account": [
      "264988854622"
     ]
    },
    "RetentionDays": 365
   },

Reproduction Steps

    const bus = new events.EventBus(this, 'bus', {
      eventBusName: 'MyCustomEventBus'
    });

    bus.archive('MyArchive', {
      archiveName: 'MyCustomEventBusArchive',
      description: 'MyCustomerEventBus Archive',
      eventPattern: {
        account: [cdk.Stack.of(this).account],
      },
      retention: cdk.Duration.days(365),
    });

    bus.grantPutEventsTo(new iam.ServicePrincipal('lambda.amazonaws.com'));

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.23.0

Framework Version

No response

Node.js Version

14

OS

MacOs/Linux

Language

Typescript

Language Version

No response

Other information

No response

moelasmar commented 2 months ago

This issue has been queued for processing by our automated system.

moelasmar commented 2 months ago

    ## Issue Processing Complete

    This issue has been processed successfully.

    You can view the processing results here: [Results](https://cdkgithubbugreproducersta-githubissueresultsbucket-anxrgpotfplp.s3.amazonaws.com/moelasmar/CodeQlDemoEcsIssue%236.txt?AWSAccessKeyId=ASIAQUFLP7FHZFVOWTMI&Signature=QqkJc9LyXOEGkQlpiqXwBFhAZ%2BI%3D&x-amz-security-token=IQoJb3JpZ2luX2VjEKb%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLXdlc3QtMiJHMEUCICXAiwN7ffe9W%2FduEsYjsYGjQVOTOrlVxIuOh2v7VyltAiEAtl3D7R5P1RtRiD6cAkVq43RmWNvHwFQyy0XbErGBrhQq5AQI7v%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FARAAGgwwNDMzMDkzMzI4MTUiDJdozId%2FPTKsgc1olCq4BCUy4VmGEGfkqUFl4w2z1VGQ6yq2jjol8n8nYzdGILGz8dYsPE6Lb3Ecp245%2FCIwYohXGlljFSk8FTF1%2FmWWv91GtzBNDewoXrzuxnuOSVGnmHFJtHYx01qOafICCYI9PrNjiVCCeM22KFKiyw1vlenJ3ErxOhJY%2FPxty9q%2B5o8Rcn%2Bpw86zQwoOZHjBdbym7yAThunT38B5FTfMpMO8v%2BGcImg2khnVUUksyrnP5rrqd7svRE3fgE5rlM9AKoLB9yVUe7rrq3A%2Bqa63260sfXxru0U4K6VSKKXwgfWgmPJIpIDAsu3QNj4SLN8EVCsdTw7Cg%2BZ4hHhVJvUEykIO14vcnP%2FfKqHzeLwjUhR0MmV7tQmDCzkxjgZfBg9Ey%2FHOCOCI8eXLS6IFzwhkqkmy2l8gWFE9ekENkpmUhcN1dfglGJI2SBfjCKjrNDIG1awezDzsGQNuUVZjZw8hkzCLjnt3WXVpQ2hkDhBu5lYovdX631Bq%2BrrNXbwfFHR3OhU2QI6i0qx0npcHCfiWWQ1C%2FgHt%2F6wZ3woml%2F7zjjFK3EZrDN8Xo%2FyDiw%2BkNCRkD0Ml50MsfUkVzw89%2FjpIeDOisoVEe54%2Bs2%2BSlZ4Ze5UPPa4j6mw6mG86PrJGOA0pusGLWegIjw%2By6c8PgMGMtik4%2F7gjacKII1mtS0TGWb8DgBfFN50gkPLFms6F7KgH%2F5a%2FaXMmqTa1%2BPR1GVu64GbTlqunK%2Fnj3NKZZXigp60ECjYPuH4Ne69rw9Mw29rQvgY6pwHBlThgmW3cUdH9DmjUcg3Ed8Oosx2ZX5bI5RzEWBemZ64eZ804%2FO1sXpzBZslB%2FF00ZzhMSUo49XLE7NauRuDZDE61UTzG1%2FrSa0VyFT6U0ZVcdTvN8%2FZbmf6Fl2MZRwGRvYidBB1SHORsTT0X1sgNR3uS2XNeLIZ2uGvvL7fxYlJRUZ5KYoSQ%2B64R78LXdnY9LVTY0HBwJOgTABmlIKseLflVIE5mWg%3D%3D&Expires=1742563311)

    *This is an automated message from the GitHub Issue Processor.*

moelasmar / CodeQlDemoEcsIssue