aws-events: Cannot grant `putEvents` to Service Principals

moelasmar commented 2 months ago

Original issue by @arcrank on 2022-09-16T15:44:27Z

Describe the bug

When trying to grantPutEventsTo an AWS SP, there is a no-op, and no warnings or errors. I would expect if we added a grant to a iam.ServicePrincipal that the underlying grant/policy would be created. We can add an SP to the event bus in the console. Tracing back code I myself didn't necessary find a place where this would have failed, or I would have expected if this was not possible to give a failure message.

Expected Behavior

I would expect the template to have grant policies attached. If for some reason you weren't allowed to add SPs, I would expect a failure message and error.

Current Behavior

Nothing is logged to the terminal when synthing the template snippet is

 "Resources": {
  "bus707364D1": {
   "Type": "AWS::Events::EventBus",
   "Properties": {
    "Name": "MyCustomEventBus"
   },
   "Metadata": {
    "aws:cdk:path": "xxx/bus/Resource"
   }
  },
  "busMyArchiveF1010141": {
   "Type": "AWS::Events::Archive",
   "Properties": {
    "SourceArn": {
     "Fn::GetAtt": [
      "bus707364D1",
      "Arn"
     ]
    },
    "ArchiveName": "MyCustomEventBusArchive",
    "Description": "MyCustomerEventBus Archive",
    "EventPattern": {
     "account": [
      "264988854622"
     ]
    },
    "RetentionDays": 365
   },

Reproduction Steps

    const bus = new events.EventBus(this, 'bus', {
      eventBusName: 'MyCustomEventBus'
    });

    bus.archive('MyArchive', {
      archiveName: 'MyCustomEventBusArchive',
      description: 'MyCustomerEventBus Archive',
      eventPattern: {
        account: [cdk.Stack.of(this).account],
      },
      retention: cdk.Duration.days(365),
    });

    bus.grantPutEventsTo(new iam.ServicePrincipal('lambda.amazonaws.com'));

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.23.0

Framework Version

No response

Node.js Version

14

OS

MacOs/Linux

Language

Typescript

Language Version

No response

Other information

No response

moelasmar commented 2 months ago

This issue has been queued for processing by our automated system.

moelasmar commented 2 months ago

    ## Issue Processing Complete

    This issue has been processed successfully.

    You can view the processing results here: [Results](https://cdkgithubbugreproducersta-githubissueresultsbucket-anxrgpotfplp.s3.amazonaws.com/moelasmar/CodeQlDemoEcsIssue%237.txt?AWSAccessKeyId=ASIAQUFLP7FHW7O2VDVA&Signature=XvJCV%2BvMAoplzoJpmCoky4SXYxI%3D&x-amz-security-token=IQoJb3JpZ2luX2VjEKb%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLXdlc3QtMiJGMEQCIGykyesGs4NW6ii5oDmzV9AYqwv3ZSOzSSLXKMfKHqFuAiALNBCNX169dYnDyIBMvIITjLDpgruvc8B8IgwNvAhQYirkBAjv%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F8BEAAaDDA0MzMwOTMzMjgxNSIMCMRyOEUy2Q%2FR5CPQKrgEAWx2hPYBjcMcoSF1DJye16%2FWgUU6lI%2FrX6s5Us7wzSg7ZjdL2ucyJG5pmskmUB5LOvlUb%2BMGqw%2F6cjeRWZfoAtcFrm1A%2FKkdsNUgOm627CYy6Xg8GSWGBKTFCxbYBS7og%2B3veYv0Rq2NNe5RlUgmRLbMpmikfjAI7qxEZo9zkN%2BBBpUu94nVYqKDl%2FAKv28%2BZrUr0qmJxI98gOVRWftbzhUIp%2FNnQ0vRvF1HPd9m3wduLw9LVg64mLrtBN7ejDNHr74KCMnhBK%2BBfQPak44h82Xn7K6nsB6AfZ27ZIOrwj84EG7XNsohmG4B3B7an5wRDYL960BEzt5tSLLCZ%2BtsoJQWAg8bokLb%2BpyRsUT%2FshIRxzjzNRxa5J%2BN%2Fl0xiU8o8OOQlCx6h3aSyFMSBL7g8jwZX5tdI%2BJqyQ3MUC5F0KdPAwkdePmtQss6xHQd%2F9%2BvCJ0V1t5FLxK06z7mJNZQjs9iFljHz1TJsXmru6uaMZwxWlk6AMXrH44ejj4cwrodF6gZyxOydziGqkrIGgk3yA%2BRi%2BuZobe5Ubii1LjsuFkUM8x9IE5Z4O1ITasjRcvuZLjAPXJH9YhZ1W7mCsyrWagyRc78ilp8jo%2BSj0yA%2BTmaiePu5lgZk9ckrbVYI1z1cCm1dusl4njZWRm2UZQT23cG%2Bgp4MhF3xp8Wklhy7ompxUJ6S3TVUVLJQAXY2Y4aKcZzvagAKkhh410mZccxxIy4o6ITPL0qzqL0twlvFup57Fd6A%2F9VijCc29C%2BBjqoAQHYqJ1XxbSfdc8Fpfw7GAKwUxWKaA1U4vF2IHJyJKurtZ1RqKtDQyX6NpJPuAVmRZh0vP5NELe5PzfafdtIwAk3gWQiur9kZMzQinQ0VcDV7YftDy3BLp8nKZ5UxPqTASAVUgqO89UxP2sCTTF4CC%2FnKZ3dX1oumMozfXopHsRd%2FRd4uMvHybUdh4cEaBiXnGp3u%2FJWvCTXvaJfvsN1KgWHVwHye0rAVw%3D%3D&Expires=1742563375)

    *This is an automated message from the GitHub Issue Processor.*

moelasmar / CodeQlDemoEcsIssue