aws-events: Cannot grant `putEvents` to Service Principals

moelasmar commented 1 month ago

Original issue by @arcrank on 2022-09-16T15:44:27Z

Describe the bug

When trying to grantPutEventsTo an AWS SP, there is a no-op, and no warnings or errors. I would expect if we added a grant to a iam.ServicePrincipal that the underlying grant/policy would be created. We can add an SP to the event bus in the console. Tracing back code I myself didn't necessary find a place where this would have failed, or I would have expected if this was not possible to give a failure message.

Expected Behavior

I would expect the template to have grant policies attached. If for some reason you weren't allowed to add SPs, I would expect a failure message and error.

Current Behavior

Nothing is logged to the terminal when synthing the template snippet is

 "Resources": {
  "bus707364D1": {
   "Type": "AWS::Events::EventBus",
   "Properties": {
    "Name": "MyCustomEventBus"
   },
   "Metadata": {
    "aws:cdk:path": "xxx/bus/Resource"
   }
  },
  "busMyArchiveF1010141": {
   "Type": "AWS::Events::Archive",
   "Properties": {
    "SourceArn": {
     "Fn::GetAtt": [
      "bus707364D1",
      "Arn"
     ]
    },
    "ArchiveName": "MyCustomEventBusArchive",
    "Description": "MyCustomerEventBus Archive",
    "EventPattern": {
     "account": [
      "264988854622"
     ]
    },
    "RetentionDays": 365
   },

Reproduction Steps

    const bus = new events.EventBus(this, 'bus', {
      eventBusName: 'MyCustomEventBus'
    });

    bus.archive('MyArchive', {
      archiveName: 'MyCustomEventBusArchive',
      description: 'MyCustomerEventBus Archive',
      eventPattern: {
        account: [cdk.Stack.of(this).account],
      },
      retention: cdk.Duration.days(365),
    });

    bus.grantPutEventsTo(new iam.ServicePrincipal('lambda.amazonaws.com'));

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.23.0

Framework Version

No response

Node.js Version

14

OS

MacOs/Linux

Language

Typescript

Language Version

No response

Other information

No response

moelasmar commented 1 month ago

This issue has been queued for processing by our automated system.

moelasmar commented 1 month ago

    ## Issue Processing Complete

    This issue has been processed successfully.

    You can view the processing results here: [Results](https://cdkgithubbugreproducersta-githubissueresultsbucket-anxrgpotfplp.s3.amazonaws.com/moelasmar/CodeQlDemoEcsIssue%238.txt?AWSAccessKeyId=ASIAQUFLP7FH7ODUHZM7&Signature=y7TTKjN3Iz6OgCp5Xj%2B5AvPJNtE%3D&x-amz-security-token=IQoJb3JpZ2luX2VjEKb%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLXdlc3QtMiJHMEUCIQC1RsdVKLOcFGxvDHqjzqfqwOXA9%2FoFjKLSMF24HSR87QIgYptJIrdJMLQXgFAS5WvXkXgvaByJwIZ2QOgfZupz1k8q5AQI7v%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FARAAGgwwNDMzMDkzMzI4MTUiDIFwtrhxCGkNxKZveyq4BLdNVYMdAgQkj0%2FZ7K9Kb3CZgSwpkEirnjUuLqgH%2FIy8Npt78Z5zC%2BXiYvNibsztWasbyhjZPHj0SoMhg3%2FUOzb4QHiLK792qYQGpOJ4cDpzbpPKJ%2BMLGnQtQHrO8ZlyOMGyY11hhrjoMveXz%2BI49HIdCaOZxbuthxzLDLJSf9P%2FbP2WLMzRyhuiYRzYgWYrI1C5m%2B088g6hHiGVYg0pA9YfjyzYCrQODDCF%2Bc24aEKxRoMviVsLJSSvfXpSEG3mLg%2Bn4B7wAhoQYOP2%2FPnG8j%2F%2FbyAKO5IDWyz6XKZXK899Fqpc3UFYGlzZuffsBOJ7zSHvOgZXjwOrM6%2FBFCPO882HZXBr2U7bssgYMbivcEzpsKn%2FxmyaYt8%2FAAzyDnaFsbTpfDWipu0cYP0ZlQFgdFZUIIHDjbEIjWBaOAHbZ6TiJNXCpR7yiFn7JxIwHHUkdgUZvqQXVa2F%2FNIhLmV8gVm9Q5hAa5hN5f6JE5BIwyeWi34CkzcYv3ULHIcoA2nn1PIP2%2B7Rlf%2FfJPolvxNDnJHPwSJ1v6ODzhvFd4DefhMn2fd39sZkE2oUHsmftz%2FSlLdPVcl2AJYB6UciLRJ86PfDxAPT2pxrYes6%2Fi0s9ktNfSfvnSkFHr8Cv04B8iL06z3SFUP5NJnjZtCGebB7WcJsPPbmNHIx%2FcHhtcDWtiBeiY2KLj6cjRQs3WrItUYGRRgNfrFJOdcJovP%2Bihogn613X4rJIjAEPz04WzngssoJHLOnT3uAR98w1trQvgY6pwFucx1Q2kdcasQ0bZODifzEmW0C8E8GJSGpCgPA2viCPXTTiWEkcrZob84gtnH1mUmlxXh2JJC6KvDQP7s2vaQVokZqrYPbHWLO9awvs8VEXOqC3md6Ab5EKFW3B%2BvHcvd6iZo5sE5k96%2BqcWkZJIfVBMW4BvMMdhRoo%2Fv2SM1TY4JKxUE%2B1xvgVDWKlAdsaMIplu39A7y1oGRnoPeUeD4XrYlwYKI%2FGw%3D%3D&Expires=1742563308)

    *This is an automated message from the GitHub Issue Processor.*

moelasmar / CodeQlDemoEcsIssue