search

mohamicorp / stash-jenkins-postreceive-webhook

Webhook used to notify Jenkins when commits are made to Stash
Other
138 stars 98 forks source link

Changing ignored commiters list from being space delimited to be comma delimited #128

Open spuklo opened 9 years ago

spuklo commented 9 years ago

I've changed behaviour of ignored committers list to expect comma delimited list of usernames rather than space separated. Reason for this change is that it happens to have username with space in it (like "build agent") and then space as delimiter doesn't really work. I've just wasted half a day at work to figure out why release commits are triggering builds while jenkins username has been on the list... ;-)

kronenthaler commented 9 years ago

+1

jan-molak commented 9 years ago

+1 A comma is much less likely to be part of a username than a space.

FabienDeshayes commented 9 years ago

+1

alex-arica commented 9 years ago

+1

mikesir87 commented 9 years ago

Well, it certainly seems that there's a lot of interest in this! So, thanks for the pull request. My only hesitation is that there are currently deployments that are still using the space delimited version which will break with this update.

If we had a way to migrate those users over, it should work out nicely. However, I haven't looked into how to pull off a "after updating the plugin, run this migration task" yet. Anyone have any ideas?

I'd like to have some sort of migration included with this pull request, as I don't want to inadvertently break current users.

spuklo commented 9 years ago

Fair comment, I've been wondering about "migration path" for existing users as well. Let me read upon Stash's plugin API, if there is anything that we can hook into. Suggestions welcome ;)

jgreen210 commented 7 years ago

Why not just make the separator a parameter in the UI, but keep the default as a space forever? Only people with unusual usernames need to change the default.