search

moishinetzer / PBandJ

Zero-Config Reusable Component Framework for React 🥜💜
MIT License
108 stars 6 forks source link

Update Node Version on Github Actions #44

Open MartinPlayon opened 10 months ago

MartinPlayon commented 10 months ago

The current GitHub actions are using 

 - uses: actions/setup-node@v3
        with:
          node-version: 16.x

This version is out of support. The point of discussion is whether to move to 20 or 18.

20 is about to become LTS, but I don't think that most images are there yet. I know that lambdas are only at 18.

moishinetzer commented 10 months ago

Feel free to open a PR lets see if CI/CD passes

MartinPlayon commented 9 months ago

Using node version 18 or 20 runs fine, and even updating most of the packages to recent versions seems to work fine, but esbuild-css-modules-plugin version 3 causes a build failure.