mojaloop / project

Repo to track product development issues for the Mojaloop project.
Other
23 stars 15 forks source link

centralkms should be removed from the helm charts as it was deprecated a number of releases ago #2754

Open tdaly61 opened 2 years ago

tdaly61 commented 2 years ago

Summary: The centralkms helm chart is still bundled in the current v13 version of the helm charts and references still exist within other helm charts. centralkms sand any references to it should be completely removed from the existing 13.x.x release of ML and all future releases.

Severity: (Low)

Priority: (medium)

Expected Behavior zero references anywhere in the helm repo to centralkms (except perhaps any older historical documentation)

Steps to Reproduce

  1. look in the existing helm repo and note that centralkms directory exists
  2. from the top of the helm repo run " grep -ril centralkms * and note the references (listed below for convenience) )

Specifications

Notes: Need to remove or inspect the following files in the helm repo: central/values.yaml centralkms/Chart.yaml centralkms/templates/ingress.yaml centralkms/templates/service.yaml centralkms/templates/config.yaml centralkms/templates/endpoint.yaml centralkms/templates/secret.yaml centralkms/templates/deployment.yaml centralkms/templates/_helpers.tpl centralkms/values.yaml centralledger/values.yaml forensicloggingsidecar/templates/ingress.yaml forensicloggingsidecar/templates/config.yaml forensicloggingsidecar/requirements.yaml forensicloggingsidecar/requirements.lock forensicloggingsidecar/configs/default.json forensicloggingsidecar/values.yaml lint-charts.sh package.sh repo/index.yaml update-charts-dep.sh

elnyry-sam-k commented 2 years ago

Thanks for the issue @tdaly61