search

mojohaus / aspectj-maven-plugin

https://www.mojohaus.org/aspectj-maven-plugin/
MIT License
114 stars 72 forks source link

Java 17 support #154

Closed xkommando closed 11 months ago

xkommando commented 2 years ago

hi guys do you have any plans to add support for java 17 (LTS)? thanks!

kriegaex commented 2 years ago

I know that you created a PR which was just merged today. Yet I am hoping that nobody minds me saying, that the AspectJ.dev variant of this plugin has fully supported Java 17 since mid 2021 already, also supports 18 and - without plugin upgrade - is ready to also support any future JDK, as soon as a compatible AspectJ version becomes available, because it does not rely on hard-coded version strings anymore since plugin version 1.13.1. The AspectJ.dev plugin also has a couple of additional little features, which you might want to take a look at. Please, decide for yourself if you need them or not. As the current maintainer of AspectJ, I am trying to make sure that the Maven plugin also stays in sync.

Having said that, I still think that diversity is good and am happy that the classic Mojohaus plugin is catching up. Because of the Mojohaus branding, it is still very popular, and it is good for AspectJ that it also supports a more recent Java LTS version. 👍 I have a lot of respect for the Apache/Mojohaus people, who are dealing with lots of projects and plugins which need to be maintained.

AG72 commented 1 year ago

We are also strongly interested in Java 17 support. Are there any plans to add this soon? Thanks for the information!

kriegaex commented 1 year ago

@AG72, what stops you from using the aspectj.dev version I mentioned above? It has all the same features that this one has plus a few more. Use it with Java 17, 18, 19 to your heart's content. Spoiler: I am the current AspectJ maintainer, you may trust me no less than the Mojohaus team. But they are really super busy and stretched thin for resources, because many of them also contribute to lots of other core Maven plugins or even to Maven itself.

AG72 commented 1 year ago

@kriegaex thanks for your quick reply. I would like to switch to aspectj.dev, but there is an issue blocking me from doing so. You may like to have a look at the issue https://github.com/dev-aspectj/aspectj-maven-plugin/issues/113 I opened over there.

slawekjaranowski commented 11 months ago

PR #155 is it enough to resolve this issue? ... or something else should be done?