search

mojohaus / aspectj-maven-plugin

https://www.mojohaus.org/aspectj-maven-plugin/
MIT License
114 stars 72 forks source link

Improve `compilerArgs` Javadoc and rename to `additionalCompilerArgs` #99

Closed kriegaex closed 3 years ago

kriegaex commented 3 years ago

Relates to #42.

TODO: write tests (out of scope here, I just wanted to improve what was recently merged).

Please note that this PR is branched off of #98. I.e. if you merge it afterwards, there will be no merge conflicts. If you prefer me to rather cherry-pick on master, I can do that too. But then maybe you have to merge, I did not check.

There will also be a subsequent PR which again builds on top of this one. I know this is unusual, so feel free to slap my face if you do not like it. I am expecting all those contributions from AspectJ.dev back into Mojohaus to be accepted quickly, though, so hopefully we can sync the two repositories ASAP and I can retire the fork. I won't do so unless what I think is important it not in upstream.

kriegaex commented 3 years ago

Please note that this PR is branched off of #98. I.e. if you merge it afterwards, there will be no merge conflicts. If you prefer me to rather cherry-pick on master, I can do that too. But then maybe you have to merge, I did not check.

There will also be a subsequent PR which again builds on top of this one. I know this is unusual, so feel free to slap my face if you do not like it. I am expecting all those contributions from AspectJ.dev back into Mojohaus to be accepted quickly, though, so hopefully we can sync the two repositories ASAP and I can retire the fork. I won't do so unless what I think is important it not in upstream.

@bmarwell, please re-read. I did nothing accidentally. ;-)

bmarwell commented 3 years ago

Please note that this PR is branched off of #98. I.e. if you merge it afterwards, there will be no merge conflicts. If you prefer me to rather cherry-pick on master, I can do that too. But then maybe you have to merge, I did not check.

There will also be a subsequent PR which again builds on top of this one. I know this is unusual, so feel free to slap my face if you do not like it. I am expecting all those contributions from AspectJ.dev back into Mojohaus to be accepted quickly, though, so hopefully we can sync the two repositories ASAP and I can retire the fork. I won't do so unless what I think is important it not in upstream.

@bmarwell, please re-read. I did nothing accidentally. ;-)

Oops, skipped that part. Fair enough 😅