search

mojotech / torch

A rapid admin generator for Elixir & Phoenix
Other
1.12k stars 80 forks source link

Update phoenix_html to 4.0.0 #448

Closed adamu closed 6 months ago

adamu commented 10 months ago

phoenix_html has been updated to v4 with breaking changes: https://hexdocs.pm/phoenix_html/changelog.html#v4-0-0-2023-12-19

I took a look at doing the migration myself, but I'm guessing this library will want to do more than the minimal changes to update and keep the code compiling, it'll probably want to avoid the dependency on the new (legacy) phoenix_html_helpers library, so I'm just opening the issue for now.

cpjolicoeur commented 10 months ago

Thanks for this @adamu

adamu commented 8 months ago

@cpjolicoeur Is there any progress on this? If you like I can work on a PR that introduces the phoenix_html_helpers library, which would stop Torch being a blocker for people updating to phoenix_html v4.

adamu commented 7 months ago

I think this can be closed now following #452 and the latest release (but heads up that the Hex docs appear to be broken).

cpjolicoeur commented 6 months ago

Thanks @adamu I'm not sure what is up with the docs but I'll look into it and republish them

cpjolicoeur commented 6 months ago

@adamu docs have been fixed and re-published. Thanks for noticing that.