search

moleike / haskell-jsonnet

🎏 Haskell implementation of Jsonnet
https://hackage.haskell.org/package/jsonnet
Other
21 stars 6 forks source link

Fix roundtrip test #47

Closed ozkutuk closed 2 years ago

ozkutuk commented 2 years ago

Closes #45

As discussed in the comments of #45, the lookup expression did not conform to the Jsonnet specification. Interestingly enough, the roundtrip test seemed to be fixed on its own after I have changed the definition of the lookup expression. Still, I have also removed the unquoted strings altogether, since they weren't really needed anymore. However, I am not 100% confident in the potential implications of this change, so it would be a good idea to review this thoroughly before merging.

ozkutuk commented 2 years ago

Pipeline seems to be failing since it can't install GHC 9.0.1. I don't know what changed since my last PR but actions/setup-haskell is marked as deprecated either way, so it might be a good idea to migrate to haskell/actions/setup.

ozkutuk commented 2 years ago

@moleike I also think that we can leave this as is and return back if it poses to be a problem once we make use of the pretty-printing module within the codebase.