Open DickPostma opened 3 weeks ago
Ah, login tests moeten nu via andere route natuurlijk, want oidc login leidt tot ander login gedrag. 1 van de devs vragen?
imo enabling oicd by default on the preview is not a good idea. Login for testing stuf stakes much longer , and lost of test setups become way more complicated. I would suggest a single ( or small set ) test to test the oidc integration.
imo enabling oicd by default on the preview is not a good idea. Login for testing stuf stakes much longer , and lost of test setups become way more complicated. I would suggest a single ( or small set ) test to test the oidc integration.
I propose we can set OidcEneabled to 'false' but keep all env variables. Than oidc can be easily switched on in the preview using changes Harm just made to switch oidc on/off via the settings.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
This only set the settings on the preview server, but the preview server is not authorised in the IdP so it doesn't work yet. The IdP will return an unauthorised client message.
Sorry, didn't know about the Draft function. I am currently still working on the PR. In this case I needed to add the secret-key in the environment of circleCI. Secrets are stored in a secret-key variant in kubernetes.
What are the main changes you did:
how to test:
todo: