mollie / Sylius

Mollie payment gateway integration for Sylius
MIT License
4 stars 17 forks source link

Missing nullable attribuite on MollieCustomer::isCreditCardSaved doctrine configuration #26

Open markbeazley opened 2 months ago

markbeazley commented 2 months ago

I had an issue upgrading the plugin due to the addition of the is_credit_card_saved column to the mollie_customer table, as it has a NOT NULL constraint but no default value so if you run it on a table that already has records the migraiton fails. Looking at the code the field is marked as a ?string and from what I can see the only values that get set are '1' and null, so I asusme there is a missing nullable="true" from this line

logeecom commented 1 month ago

Hello @markbeazley,

Thank you for reaching out to us regarding this issue.

Please note that our team is taking a look at the reported issue.

As soon as we have more information to provide, we will let you know.

Thank you,

Kind regards.

logeecom commented 1 month ago

Hello @markbeazley,

Thank you for your patience,

Note that in the orm xml, flag nullable="true" should be added, since in the migration, the default value is already set to null.

Our team will apply this fix and we will let you know as soon as it is done.

Kind regards.

markbeazley commented 1 month ago

@logeecom Thanks, its probably only an issue for people running on a database other than MySql (we use PostgreSQL) so need to generate our own migrations rather than copying/using the ones in the plugin.

logeecom commented 1 month ago

Hello @markbeazley,

Please note that the fix for this issue will be live with our next release.

We expect to release a new version of the plugin at the beginning of next week. We will notify you as soon as it becomes available.

Thank you,

Kind regards.

logeecom commented 1 month ago

Hello @markbeazley,

Note that Molle plugin version 5.7.1 is live.

This version encompasses a fix for the issue reported in this ticket.

If you have any questions or concerns, feel free to let us know.

Kind regards.