mollyim / mollysocket

MollySocket allows getting Signal notifications via UnifiedPush.
GNU Affero General Public License v3.0
106 stars 10 forks source link

What means: Failed to decode protobuf? #21

Closed albirs closed 9 months ago

albirs commented 10 months ago

after some hours of running mollysocket (as container in portainer) i found in the logs this error: . . . [2023-12-20T13:30:11Z INFO mollysocket::ws::websocketconnection] WebSocket handshake has been successfully completed [2023-12-20T13:36:07Z INFO rocket::server] GET / text/html: [2023-12-20T13:36:07Z INFO rocket::server::] Matched: (discover) GET / [2023-12-20T13:36:07Z INFO rocket::server::] Outcome: Success(200 OK) [2023-12-20T13:36:07Z INFO rocket::server::] Response succeeded. [2023-12-20T20:27:34Z ERROR mollysocket::ws::websocket_connection] Failed to decode protobuf: failed to decode Protobuf message: invalid wire type value: 7 [2023-12-20T20:27:34Z WARN mollysocket::ws::websocket_connection] Websocket finished [2023-12-20T20:27:34Z INFO mollysocket::ws::signalwebsocket] Retrying to connect in 10 secondes. [2023-12-20T20:27:44Z INFO mollysocket::ws::websocket_connection] WebSocket handshake has been successfully completed [2023-12-20T20:43:34Z ERROR mollysocket::ws::websocket_connection] Failed to decode protobuf: failed to decode Protobuf message: invalid wire type value: 7 [2023-12-20T20:43:34Z WARN mollysocket::ws::websocket_connection] Websocket finished . . . .

after restart the container the error has gone for now...

I couldn't find any meaningful information about this error on the internet

Thank you very much

p1gp1g commented 10 months ago

Protocol buffer wire type 6 and 7 do not exist, the buffer must be corrupted: https://protobuf.dev/programming-guides/encoding/#structure

albirs commented 9 months ago

... and is this an problem for that mollysocket works properly and needs to fix it? or doesn't matter?

p1gp1g commented 9 months ago

Does it happen often to you ? It shouldn't be a problem, mollysocket reconnects afterwards

albirs commented 9 months ago

its very irregularly, one day up to 7 times, other day it not happen...

p1gp1g commented 9 months ago

I'm seeing this with the same recurrence too. We can ignore it

againstpetra commented 9 months ago

I'm also seeing this in mollysocket's log. mollysocket remains completely functional

p1gp1g commented 9 months ago

I think we can close this issue. If you see this error, you can ignore it.

albirs commented 6 months ago

after update to version 1.3.0 i just notice that this message appears every 5-6min now:

09T19:57:49Z ERROR mollysocket::ws::websocket_connection] Failed to decode protobuf: failed to decode Protobuf message: invalid wire type value: 7 [2024-04-09T19:57:49Z WARN mollysocket::ws::websocket_connection] Websocket finished [2024-04-09T19:57:49Z INFO mollysocket::ws::signalwebsocket] Retrying to connect in 10 secondes. [2024-04-09T19:57:59Z INFO mollysocket::ws::websocket_connection] WebSocket handshake has been successfully completed [2024-04-09T20:02:50Z ERROR mollysocket::ws::websocket_connection] Failed to decode protobuf: failed to decode Protobuf message: invalid wire type value: 7 [2024-04-09T20:02:50Z WARN mollysocket::ws::websocket_connection] Websocket finished [2024-04-09T20:02:50Z INFO mollysocket::ws::signalwebsocket] Retrying to connect in 10 secondes. [2024-04-09T20:03:00Z INFO mollysocket::ws::websocket_connection] WebSocket handshake has been successfully completed [2024-04-09T20:08:01Z ERROR mollysocket::ws::websocket_connection] Failed to decode protobuf: failed to decode Protobuf message: invalid wire type value: 7 [2024-04-09T20:08:01Z WARN mollysocket::ws::websocket_connection] Websocket finished [2024-04-09T20:08:01Z INFO mollysocket::ws::signalwebsocket] Retrying to connect in 10 secondes. [2024-04-09T20:08:12Z INFO mollysocket::ws::websocket_connection] WebSocket handshake has been successfully completed [2024-04-09T20:13:22Z ERROR mollysocket::ws::websocket_connection] Failed to decode protobuf: failed to decode Protobuf message: invalid wire type value: 7 [2024-04-09T20:13:22Z WARN mollysocket::ws::websocket_connection] Websocket finished [2024-04-09T20:13:22Z INFO mollysocket::ws::signalwebsocket] Retrying to connect in 10 secondes. [2024-04-09T20:13:33Z INFO mollysocket::ws::websocket_connection] WebSocket handshake has been successfully completed [2024-04-09T20:18:53Z ERROR mollysocket::ws::websocket_connection] Failed to decode protobuf: failed to decode Protobuf message: invalid wire type value: 7 [2024-04-09T20:18:53Z WARN mollysocket::ws::websocket_connection] Websocket finished [2024-04-09T20:18:53Z INFO mollysocket::ws::signalwebsocket] Retrying to connect in 10 secondes. [2024-04-09T20:19:03Z INFO mollysocket::ws::websocket_connection] WebSocket handshake has been successfully completed [2024-04-09T20:24:34Z ERROR mollysocket::ws::websocket_connection] Failed to decode protobuf: failed to decode Protobuf message: invalid wire type value: 7 [2024-04-09T20:24:34Z WARN mollysocket::ws::websocket_connection] Websocket finished [2024-04-09T20:24:34Z INFO mollysocket::ws::signalwebsocket] Retrying to connect in 10 secondes. [2024-04-09T20:24:44Z INFO mollysocket::ws::websocket_connection] WebSocket handshake has been successfully completed [2024-04-09T20:30:25Z ERROR mollysocket::ws::websocket_connection] Failed to decode protobuf: failed to decode Protobuf message: invalid wire type value: 7 [2024-04-09T20:30:25Z WARN mollysocket::ws::websocket_connection] Websocket finished [2024-04-09T20:30:25Z INFO mollysocket::ws::signalwebsocket] Retrying to connect in 10 secondes. [2024-04-09T20:30:35Z INFO mollysocket::ws::websocket_connection] WebSocket handshake has been successfully completed [2024-04-09T20:36:26Z ERROR mollysocket::ws::websocket_connection] Failed to decode protobuf: failed to decode Protobuf message: invalid wire type value: 7 [2024-04-09T20:36:26Z WARN mollysocket::ws::websocket_connection] Websocket finished [2024-04-09T20:36:26Z INFO mollysocket::ws::signalwebsocket] Retrying to connect in 10 secondes. [2024-04-09T20:36:36Z INFO mollysocket::ws::websocket_connection] WebSocket handshake has been successfully completed

may this help: https://github.com/protobufjs/protobuf.js/issues/1927#issuecomment-1694949696 (last comment at the moment from Aug-28-2023)

epif4nio commented 6 months ago

I also see this occurring every 5 minutes or so. Maybe we can ignore it but it's still noise in the logs. Can we do something to fix it?