mom-ocean / MOM6

Modular Ocean Model
Other
185 stars 232 forks source link

dev emc candidate 20230122 #1618

Closed jiandewang closed 10 months ago

jiandewang commented 10 months ago

This PR contains two NUOPC cap enhancements: (1) switch to cesm style field names so that field names were aligned with those in https://github.com/ESCOMP/CMEPS/blob/main/mediator/fd_cesm.yaml (see detail at https://github.com/NOAA-EMC/MOM6/pull/120)

(2) add non-interval restart writing capability: this requirement is from EMC DA group which requires to write out restart files at irregular time frequency. (see detail at https://github.com/ufs-community/ufs-weather-model/issues/1976)

both of the them have been pre-tested from NCAR side (thanks @alperaltuntas)

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e35f389) 37.91% compared to head (c8a7325) 37.91%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1618 +/- ## ======================================= Coverage 37.91% 37.91% ======================================= Files 269 269 Lines 77155 77155 Branches 14164 14164 ======================================= Hits 29254 29254 Misses 42623 42623 Partials 5278 5278 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jiandewang commented 10 months ago

Changes are outside the scope of FMS driver - hence do not impact GEOS applications.

Having said that, fyi, in GEOS coupled model, restart can be written out at any desired frequency using this.

@sanAkel thanks for the information.

alperaltuntas commented 10 months ago

I am currently testing this pr. There appears to be a small but consistent slow down ( 2-3%) that I am trying to track down. Will keep you updated.

jiandewang commented 10 months ago

thanks for everbody's time and effect, I am going to merge this to main.