search

momentarylapse / tsunami

A simple but powerful audio editor
GNU General Public License v3.0
77 stars 6 forks source link

[windows] Some bugs #18

Closed DreadDendy closed 2 weeks ago

DreadDendy commented 1 month ago

Hi, I have tested Tsunami a bit and I have found some bugs.

  1. Some icons are low-res and some widgets looks deformed icon_sizes
  2. When app window is not full-screen there is a weird black frame around it win_gtk_weird
  3. When I try to select another source (driver or channel) for audio recording then the application just freezes.
  4. (may be not a bug due to current stage of development) In order to launch application I had to install Visual Studio Community 2022 because DAW requires some dlls for debug and development:
    • msvcp140d.dll
    • vcruntime140d.dll
    • vcruntime140_1d.dll
    • ucrtbased.dll
momentarylapse commented 1 month ago

Oh, that is highly valuable information. Thank you very much!

  1. (missing dlls) was an easy fix. I reuploaded the zip file with those files included. Hope there are no others missing. Yes, I admit, the Windows release is experimental. Will need to find a test system without Visual Studio installed.

  2. Missing and low res icons are a known issue (also on MacOS). Somehow the gtk library comes with an incomplete icon theme. I'll try to find a way to include them and reupload.

1b. The stretched on/off switch is a bug in my code (the wrapper around gtk). Managed to fix in other places, but overlooked it here. Will fix soon.

1c. The overly large icons for the recording controls are ugly but intentional. Needed them on a touch screen. Will keep it for now, until a better design idea comes around. But I'm open for suggestions.

  1. (black bars) Weird. Very likely a problem with gtk trying to render transparent shadows around window frames and failing to activate alpha blending. Might be an issue of gtk itself (if it also affects programs like GIMP). Or maybe my export is still missing some files. Will do some research.

  2. (freeze) Reproduced. Yes, that's a clear bug. Should not take too long to fix.

DreadDendy commented 1 month ago
  1. I uninstalled Visual Studio and checked again. Still not working without Visual Studio. This time error 0xc000007b on launch. I think it is because those dlls are for debugging in Visual Studio. So it is basically debug build, not release build. Probably release build will not require these ones and will rely just on Visual C++ Redistributable.
momentarylapse commented 1 month ago

Ok, good to know. Yes, I had planned to make a "release" build, but Visual Studio recently fails during the (cmake) configuration process. Switching to "debug" still works.

I took down the Windows binaries for now. Will try again in a couple of days, but for now I'm too frustrated with Visual Studio.

The freeze (3.) turned out to be 2 bugs. One is clearly in my code and I managed to fix. The second seems to be strange behavior in the portaudio library (the default backend on Windows). Switching recording devices now works, but switching back fails to re-open the device. Still looking for a work-around.

Sorry and thanks a lot for your support!

momentarylapse commented 3 weeks ago

minor update: got my Visual Studio to produce "release" builds again. Also successfully tested on a clean (VM) install of Windows.

I'm optimistic to solve the icons issue in the following days. Then I'll upload again.

momentarylapse commented 2 weeks ago

I've uploaded another version (marked "EXPERIMENTAL" this time)

what (hopefully) works:

what is still incomplete:

But these issues will have to wait till a later release.

Please, if you can spare a minute, could you download and try again?

DreadDendy commented 2 weeks ago

Hello. I have tried and I can confirm that these problems have been fixed.

momentarylapse commented 2 weeks ago

That is good to hear. Feel free to add more complaints. Thanks a lot!