"No error" json_last_error_msg

monero-integrations / monerophp

Monero PHP library + JsonRPC Client

MIT License

120 stars 76 forks source link

"No error" json_last_error_msg #93

Closed davemodis closed 5 years ago

davemodis commented 5 years ago

jsonRPCClient.php on line 107 make false error when json_last_error_msg returns "No error" message. fix: $this->validate( !is_null($jsonErrorMsg) && $jsonErrorMsg !== 'No error' , $jsonErrorMsg . ': ' . $responseMessage);

serhack commented 5 years ago

Hey, thank you for the fix. Next time you could use the precious "Pull request" feature :- ) so your contribution will be counted on your Github profile.