rbrunner7
commented
1 month ago <rbrunner7> Meeting time. Hello! https://github.com/monero-project/meta/issues/980
<jeffro256> Howdy
<jberman> howdy
<dangerousfreedom> No pre-meeting message and no greetings from rbrunner7 . I hope he is fine :)
<dangerousfreedom> Hello
<rbrunner7> Well, then maybe something is not ok with Matrix?
<sneedlewoods_xmr> hey
<rbrunner7> Alright. What are the reports from past week?
<rbrunner7> I tried to update our branch, as can be seen in the backlog. I think I know now how to do it. Thanks, jeffro256
<jberman> guess it's us 3 :)
<moneromooo> I see rbrunner7's lines fwiw. Get on IRC ?
<sneedlewoods_xmr> I don't think rbrunner forgot about the meeting, because we talked about the meeting earlier
<dangerousfreedom> Ok, from my side: this week I have been unifying my code to present a coherent work. Next week I will probably have something to show and I will be studying the possible modifications on the knowledge proofs with jeffro's changes.
<rbrunner> Can everybody by chance read me if I write on IRC?
<sneedlewoods_xmr> I had a look at #31 & #34 from jeffro, maybe could review #31, but I'm not sure my understanding is good enough to be of much value.
<jberman> Update: I rebased and resolved merge conflicts on background sync PR 8619, that should be ready to go.
<jberman> Seraphis lib async scanner: I pushed a functional test framework for Seraphis wallet lib -> live RPC daemon (and wallet2 -> RPC daemon) interactions: https://github.com/UkoeHB/monero/pull/23/files/aff28f13ec95fddeb7f47e1300db31bc34886137..1893f649cb40360f89c498ef233179e7d45b2f2f
<jberman> I think this test framework can come in handy as the Seraphis lib is built up and used in a full-fledged wallet (can use this framework to test migrating from a wallet2 instance -> Seraphis lib wallet then transacting w/seraphis lib, or populating a wallet2 instance from the Seraphis lib enote store and sending valid txs pre-Seraphis fork, or to eventually test the complete end-to<clipped message>
<jberman> -end Seraphis lib -> live daemon flow, etc.).
<jberman> It's divided into 3 commits. Commit 1: a helper simple daemon RPC client. Commit 2: sets up the wallet2 <> live RPC daemon test framework not using anything from Seraphis lib. Commit 3: adds tests for Seraphis lib async scanner <> live RPC daemon
<jberman> I can PR Commits 1 and 2 to the Monero repo whenever (i.e. today), and then Commit 3 builds on top of that framework to test the async scanner in the Seraphis lib
<jberman> This week/next I'm hoping to finish review on jeffro256 's 9135 PR to write txs to disk once instead of twice on sync, review SNeedlewoods' PR for LegacyEnoteOriginContext, make the async scanner backwards compatible with existing daemons, and clean it up so it's ready for review.
<sneedlewoods_xmr> And I did some more research for this issue https://github.com/UkoeHB/monero/issues/27 and will probably have something to work with/ask questions about soon.
<0xfffc> (I am following the discussion. But don’t have anything to share in this meeting)
<dangerousfreedom> SNeedlewoods: the main goal of your PR is to make jberman 's scanner compatible for all the Monero versions?
<sneedlewoods_xmr> But first I'd like to get input on how to proceed with my first PR in regards to this comment from rbrunner https://github.com/seraphis-migration/monero/pull/16#issuecomment-2002391965
<sneedlewoods_xmr> Do all the changes belong to the `seraphis_lib` branch in `UkoeHB/monero`? Then I would close the PR, rebase it locally and make a new PR to that branch!?
<sneedlewoods_xmr> Or do some of the changes actually belong to the `seraphis_wallet` branch and the PR needs to get split up?
<jberman> that PR is necessary in order for the Seraphis wallet lib scanner to be able to scan enough data to be able to construct a pre-RCT ring on today's daemon version
<dangerousfreedom> Awesome jberman !
<rbrunner7> Can everybody who can read this please give me a quick "thumbs up" or feedback?
<jeffro256> +1
<jeffro256> SNeedlewoods: it just adds the legacy enote context struct and utils yeah? Then you can probably rebase then PR to ukoes repo
<dangerousfreedom> Yes! I think it would be better to PR into koe's seraphis_lib
<sneedlewoods_xmr> thanks jberman, you can explain it better than I could
<rbrunner> Can everybody who can read this please give me a quick "thumbs up" or feedback?
<dangerousfreedom> https://github.com/UkoeHB/monero/tree/seraphis_lib
<sneedlewoods_xmr> I first started development on the `seraphis_lib` but iirc someone told me to move to `seraphis_wallet` but I don't remember the reasoning
<rbrunner7> It's a conspiracy against me as the moderator of this meeting :)
<jeffro256> rbrunner7: I can read both lol
<jeffro256> I think it's fine where it is honestly
<rbrunner7> I wanted to discuss this repo and PR question, and have a strong opinion that everything that modifies Seraphis lib code should go to koe's branch
<jeffro256> That's fair
<rbrunner7> But well ... maybe copy that over, jeffro256 , for the others to read lol
<dangerousfreedom> Well, if nobody has other things to share then I guess this is it
<jeffro256> dangerousfreedom: that PR for direct serialization will be PRed in a couple hours
<jberman> I got nothin else, excited for that test framework too :)
<jeffro256> Sorry I didn't get to it earlier its just I did a lot of traveling
<jeffro256> Rbrunner7 said: "I wanted to discuss this repo and PR question, and have a strong opinion that everything that modifies Seraphis lib code should go to koe's branch"
<dangerousfreedom> Next week I'm planning to show a demonstrator of opening a wallet, making a mock transaction, visualizing enotes and making some knowledge proof. So the goal would be to use these three components EnoteStore, KeyContainer and TxHistory. This could open discussions about the (modular) wallet design. Next I will definitely try to understand more about the daemon and the node connection.
<rbrunner> That Matrix is not in the mood to forward what I write with Matrix user "rbrunner7" is one thing, but that people can't read "rbrunner" from IRC either is pretty strange
<sneedlewoods_xmr> that sounds promising
<jberman> I forgot, I actually was hoping to also discuss progression toward a release of a usable wallet lib so devs could start using the updated lib
<rucknium> rbrunner: I can see your messages from IRC and Matrix both.
<dangerousfreedom> Which wallet lib? For wallet2?
<jberman> to replace wallet2
<rucknium> jeffro and I are both on the monero.social Matrix servers. Maybe that has something to do with it.
<dangerousfreedom> How would that be different from jeffro's api of wallet2 ?
<dangerousfreedom> (if we can call it an api)
<rbrunner7> Rucknium: Thanks for the feedback, could be, yes.
<jeffro256> The wallet2_basic API only has loading and storing capabilities RN. we need to add tx construction to it
<jberman> hmm can you link me what you're referring to?
<jberman> and/or expand on that? iirc jeffro mentioned interest in designing an API, but nothing concrete settled yet there
<dangerousfreedom> https://github.com/jeffro256/monero/tree/wallet2_conv
<jberman> oh gotcha, ya
<dangerousfreedom> I think he tried to PR
<dangerousfreedom> https://github.com/monero-project/monero/pull/8923
<dangerousfreedom> I thought it was already on monero
<dangerousfreedom> Apparently not
<jeffro256> Here it is merged in seraphis_wallet: https://github.com/seraphis-migration/monero/tree/seraphis_wallet/src/wallet/wallet2_basic
<rbrunner7> That's pretty dumb, to be be mere spectator on "my" meeting :)
<jeffro256> IIRC wallet2_conv is a little outdated
<jberman> I was more so hoping to discuss path toward getting a lib into wallet devs' hands that's using the Seraphis lib. that PR is one element of that path, since we'll need to migrate from a wallet2 instance -> Seraphis lib-backed instance of a wallet
<jberman> that PR got merged over here looks like: https://github.com/seraphis-migration/monero/pull/4
<jeffro256> Are you saying getting the API design done before the implementation for wallet3 ?
<dangerousfreedom> Oh yes, into our project.
<dangerousfreedom> I think this is very useful (at least for me). Do you have any case in mind where it fails you?
<dangerousfreedom> Do you need something extra from wallet2?
<jberman> have you started using that to populate an enote store?
<dangerousfreedom> I tried to use that for the legacy knowledge proofs
<dangerousfreedom> But I have to revisit again, it may not be the way we want to do it
<dangerousfreedom> So, no.
<jberman> I haven't given it a good look, I don't have an opinion on it from that end
<rbrunner7> Trying a last time, from the Linux Element app instead of the web app in Chrome. Can anybody not with monero.social as their homeserver read this?
<jberman> I'm thinking would be nice to start thinking through / planning using that wallet2 converter, the async scanner, and the enote store to get a Seraphis-lib backed sdk into wallet dev's hands
<dangerousfreedom> Yes! I think one needs only to put all the pieces together. You and jeffro already did the bulky work
<jberman> I think once the scanner is out the door + SNeedlewoods PR is done, we can move toward the goal of constructing legacy txs pre-fork
<jberman> and populating an enote store from a wallet2 instance
<dangerousfreedom> Yeah, maybe SNeedlewoods would like to that ? So it would give a real meaning to his work on the Legacy Enotes. Could be very interesting
<dangerousfreedom> Yeah, maybe SNeedlewoods would like to do that ? So it would give a real meaning to his work on the Legacy Enotes. Could be very interesting
<jeffro256> Same thing: can anyone read my messages ?
<sneedlewoods_xmr> I should probably stick to things that don't need to be delivered fast, because I'm very slow
<moneromooo> jeffro256: I can, fwiw.
<rbrunner7> Somehow I hope not, lol, because otherwise I start to feel targeted :)
<dangerousfreedom> I think it would be great to learn about all the other components. You can always ask for help too
<jberman> I think we've got a bit of time until this current slate of work is in ready-state (legacy enote PR + the scanner) and next tasks are ready. but I generally wanted to get thoughts forming on path toward shipping a usable lib using these components
<rbrunner7> Does anybody who can read me happen to know who babysits the monero.social Matrix server?
<dangerousfreedom> My opinion is that the more tools we have the better. It cant go wrong now. I think it would be useful for many applications and tests also.
<jberman> We'll need a way to:
<jberman> A) populate a Seraphis lib-backed instance from an existing wallet2 instance
<jberman> B) construct legacy txs (by populating a wallet2 instance from a Seraphis-lib backed instance, then constructing a tx with wallet2)
<jberman> Once those are done, we can then move on toward ensuring the Seraphis-lib backed wallet supports the features that wallet devs will want, then ship a lib that wallet devs can start using today
<sneedlewoods_xmr> alright, I'll have a look and put some thoughts to it
<moneromooo> rbrunner7: I think sgp might be involved, but I'm really not sure.
<rucknium> rbrunner7: IIRC it's Dan Miller
<dangerousfreedom> Why is B) necessary ?
<jberman> because we want to ship the Seraphis lib before the Seraphis fork, and so wallets will still need a way to construct legacy txs. The approach to use a wallet2 instance that's populated in-memory on demand seemed a fairly sane approach to me: https://github.com/seraphis-migration/wallet3/issues/48
<dangerousfreedom> I see, this path looks safer indeed
<UkoeHB> I have been struggling to find space for pending PR reviews (which require all my brain power). Hopefully later this week, but we all know how much timeline promises go.
<UkoeHB> how my*
<rbrunner7> Thanks, UkoeHB, for the info. I hope we will manage to make it known to all people, not just the people on the monero.social Matrix server
<jberman> SNeedlewoods: if you do start looking into this soon (which it's fine if you focus on other stuff for now like those edge cases I think), I think the test framework I just pushed for the async scanner would also come in handy to mess around with. It can be useful to see what it's like to use the wallet2 instance to construct txs, and start getting a sense for routes to make wallet<clipped message>
<jberman> 2 <> Seraphis lib play nice
<sneedlewoods_xmr> yeah I took a lot of notes from what you guys mentioned here and will do my homework
<jberman> awesome, approaching the end of the hour now
<dangerousfreedom> Thanks for the discussion guys
<sneedlewoods_xmr> thank you guys, until next week
On Monday, November 14 2022, we started with regular weekly meetings of the Seraphis wallet workgroup, and all interested parties from the community that want to join. Time is 18:00 UTC on each Monday. "Location" is the Matrix room No Wallet Left Behind, #no-wallet-left-behind:monero.social (Matrix.to link), Libera IRC channel #no-wallet-left-behind.
You find the log of the last meeting here: https://github.com/monero-project/meta/issues/977