search

monero-project / monero-site

https://getmonero.org
BSD 3-Clause "New" or "Revised" License
287 stars 391 forks source link

Revert "Workflows: userguide index alphabetic test" #2008

Closed erciccione closed 1 year ago

erciccione commented 2 years ago

This reverts commit 51ff4aa146d903701ac053e337823c44e8d0bcc1.

The commit (PR #1973) adds alphabetical order for user guides, but it works only for English and it's broken for all other languages. Reverting to fix unless there is a better option.

netlify[bot] commented 2 years ago

Deploy Preview for barolo-time-757cf9 ready!

Name Link
Latest commit 09ba8f4091ad7804ae10d373c3ba7483f30bcb80
Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/62e4dc01a7f0fb000819a5f1
Deploy Preview https://deploy-preview-2008--barolo-time-757cf9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

plowsof commented 2 years ago

just following the rules in the readme "Add guide using markdown in the correct category, and in alphabetic order," which i added as a feature of the automated create a user guide script here https://github.com/plowsof/userguide-drafts/tree/main/helper-scripts/make-a-guide

can you clarify what broken means? perhaps i can only have it trigger when the English version is modified if this is providing a false positive

please modify this PR to remove the alphabetic rule from the readme.