search

monero-project / monero

Monero: the secure, private, untraceable cryptocurrency
https://getmonero.org
Other
9.04k stars 3.12k forks source link

RPC get_bulk_payments pagination #2158

Open 34ro opened 7 years ago

34ro commented 7 years ago

Hi, I think get_bulk_payments api needs pagination. As increase number of transfer, getting all transfer without omission is difficult. To use "min_block_height" is not good way to get all transfer in some cases. If some transfer relayting to my address are in one block, If many transfer exist after min_block_height, and so on.

Please give me opinion.

khantahirx commented 7 years ago

Can you address this more extensively so that i can try and write something for it ?

dEBRUYNE-1 commented 6 years ago

+proposal

34ro commented 6 years ago

If we deposit/withdraw much time, the size of transaction data will up to infinity. For preventing client application from getting memory overflow, we need pagination for get_bulk_payments.

emesik commented 5 years ago

There's min_block_height parameter which serves that purpose. Just check the current blockchain height when querying for payments and keep that value at the client side. Next time you ask for new blocks only.