crypto: remove unused OAES code

monero-project / monero

Monero: the secure, private, untraceable cryptocurrency

https://getmonero.org

Other

9.05k stars 3.12k forks source link

crypto: remove unused OAES code #9505

Open jeffro256 opened 1 month ago

jeffro256 commented 1 month ago

@SyntheticBird45 reported that the OpenBSD compiler gives warnings about string functions used in oaes_sprintf, as well as use of rand() in oaes_key_gen. Neither of these functions are used in the codebase. Removing the unused OAES functions silences these warnings.

openbsd_oaes_warnings

SyntheticBird45 commented 1 month ago

stillwarning

Still 1 warning left (if we forget easylogging++). Build profile:

$ cmake -DBUILD_TESTS=off -DCMAKE_BUILD_TYPE=release-static
$ gmake

jeffro256 commented 1 month ago

Oops, I pushed an extra commit. Reverted. @SyntheticBird45 can you test now?