search

monero-project / monero

Monero: the secure, private, untraceable cryptocurrency
https://getmonero.org
Other
9.04k stars 3.12k forks source link

release: drop 32-bit android target #9528

Open tobtoht opened 1 month ago

tobtoht commented 1 month ago

According to @nahuhh these binaries haven't worked in years (see also: https://github.com/monero-project/monero/issues/8889#issuecomment-1583469451).

Android has mostly moved on to 64-bit: https://android.stackexchange.com/questions/253596

In a 2020 blog post ARM stated that "nearly 90 percent of today’s Android devices deploy a 64-bit capable version of the OS."

This target isn't built in depends CI.

MrCyjaneK commented 1 month ago

@nahuhh / @tobtoht maybe those binaries didn't work, but wallet_api target is what is important for mobile wallets, even if that stats are accurate that's still 1 in 10 people who wouldn't be able to run monero wallet on their phone, at least not one based on the official code.

I'm strongly against removing support for something that is still supported by upstream (android still builds fine for 32bit arm, together with it still being supported target in the NDK), and something that is still being used.

tobtoht commented 1 month ago

@MrCyjaneK I reduced the scope to official releases.

Do you happen to have 32-bit ARM Android hardware? If so, could you test if the monerod release binary works?

MrCyjaneK commented 3 weeks ago

@tobtoht missed this comment, I can test it in a couple weeks when I'll be back at home, I do have one device. However I don't really see this as a required test as armv6 devices are rather low-end and wouldn't contribute much to the network anyway.. what I can confirm though is that wallet_api is working properly on armv6 devices.

tobtoht commented 3 weeks ago

@MrCyjaneK Just to clarify, the intent of this PR is not to remove 32-bit android build support for wallet_api, that was a hasty mistake as you rightly pointed out. Rather, I'm questioning whether we should continue to release official binaries for this target. Shipping broken binaries is pointless, and fixing them might be a waste of time as the hardware fades into obscurity.