mongoid / mongoid-grid_fs

A pure Mongoid/Moped implementation of the MongoDB GridFS specification.
Other
83 stars 50 forks source link

Loosen mime-types gem requirement #34

Closed philostler closed 10 years ago

philostler commented 10 years ago

Required for 2.0 release of mime-types

No change to mime-types method sig that mongoid-grid_fs uses.

philostler commented 10 years ago

Could we ideally have a gem release as well pls?

philostler commented 10 years ago

Duly noted and updated.

philostler commented 10 years ago

On a side note, may I suggest hooking this project up to Travis CI for automated testing if it's possible or improving the local testing experience. Running the tests on this project is a challenge in itself sometimes and proves to be a bit of a barrier to contribution IMHO.

rmm5t commented 10 years ago

@philostler Thanks for the fast turnaround. However, I'm not able to get a passing build. Did the test suite work for you? I actually got an error trying to load rails through mongoid. I'm on the run at the moment. I'll try to come back to this later, but in the meantime, if you can let me know if you can reproduce, that would help.

/Users/rmcgeary/work/oss/mongoid-grid_fs/vendor/ruby/2.0.0/gems/mongoid-3.1.5/lib/mongoid/railtie.rb:5:in `require': cannot load such file -- rails (LoadError)

may I suggest hooking this project up to Travis CI for automated testing if it's possible or improving the local testing experience.

Yes. That! It would make my life easier too. Unfortunately, I don't have the credentials to do that. @ahoward needs to take this step. I'd be happy to add a .travis.yml file. In fact, I added the gemfiles directory in preparation for Travis CI builds.

Could we ideally have a gem release as well pls?

I also don't have the credentials to do this either. Please feel free to email @ahoward directly and nudge him. He doesn't subscribe to any GitHub notifications that I'm aware of.

fred commented 10 years ago

so, when is this getting fixed? many gems now have upgraded to mime-types 2.0 and now having a dependency nightmare.

ahoward commented 10 years ago

@rmm5t et al.


a:~/git/ahoward/mongoid-grid_fs $ grep mime-types lib/mongoid-grid_fs.rb 
            'mime/types'      => [ 'mime-types'      , '>= 1.19', '< 3.0'] ,

a:~/git/ahoward/mongoid-grid_fs $ grep mime mongoid-grid_fs.gemspec 
    spec.add_dependency(*["mime-types", ">= 1.19", "< 3.0"])

a:~/git/ahoward/mongoid-grid_fs $ rake test

=======================================================================================================================
@1 => ruby -I ./lib -I ./test/lib /Users/ahoward/git/ahoward/mongoid-grid_fs/test/mongoid-grid_fs_test.rb
-----------------------------------------------------------------------------------------------------------------------
Run options: 

# Running tests:

..................

Finished tests in 0.862773s, 20.8630 tests/s, 130.9730 assertions/s.

18 tests, 113 assertions, 0 failures, 0 errors, 0 skips
-----------------------------------------------------------------------------------------------------------------------
@1 <= SUCCESS
-----------------------------------------------------------------------------------------------------------------------

a:~/git/ahoward/mongoid-grid_fs $ ls pkg/mongoid-grid_fs-1.9.2.gem 
pkg/mongoid-grid_fs-1.9.2.gem

a:~/git/ahoward/mongoid-grid_fs $ gem install mongoid-grid_fs
Fetching: mongoid-grid_fs-1.9.2.gem (100%)
Successfully installed mongoid-grid_fs-1.9.2
1 gem installed

a:~/git/ahoward/mongoid-grid_fs $ grep mime mongoid-grid_fs.gemspec 
    spec.add_dependency(*["mime-types", ">= 1.19", "< 3.0"])