search

mongoid / mongoid-slug

Generates a URL slug/permalink based on fields in a Mongoid-based model.
https://github.com/mongoid/mongoid-slug
MIT License
492 stars 164 forks source link

updated Mongoid to v. 6 #231

Closed moodlemags closed 7 years ago

dblock commented 8 years ago

Looks good. Amend the changelog with the pull request number please and try to squash your commits (good exercise).

dblock commented 8 years ago

Code looks good, but you still need to add mongoid 6 to https://github.com/mongoid/mongoid-slug/blob/master/.travis.yml, which is the CI so it actually runs tests against 6.0.

dblock commented 8 years ago

Bump @moodlemags. See my comment above.

dblock commented 8 years ago

Squash your commits as well to make this a single commit with a nice the description.

Fudoshiki commented 8 years ago

Hi, @dblock you can squash PR commits on accepting it with squash commits option

dblock commented 8 years ago

@Fudoshiki Thanks. I was helping @moodlemags IRL make her first (second) open-source PR, while github lets you squash commits it's good practice.

Anyone wants to finish this?

moodlemags commented 8 years ago

@dblock Oh my gosh! I got so focused on the other one this one slipped past. I am on it!

moodlemags commented 8 years ago

@dblock umm so I seem to have accidentally rebased everything and have been trying to undo it and cannot. Is it possible? I'm considering making just a new branch and doing from that. Eek!

dblock commented 8 years ago

New branch can work too, feel free to close this and reopen a new PR. Or you can force push over your other branch.

dblock commented 8 years ago

Alright! Now the build is failing for a legit reason, see https://travis-ci.org/mongoid/mongoid-slug/jobs/168612055.

moodlemags commented 8 years ago

it is sneaky! I have found where just figuring out the how to fix now

dblock commented 8 years ago

It's probably missing the paranoia gem for mongoid 6. It used to be part of mongoid and was moved into being an external dependency around version 4.

marceloboeira commented 7 years ago

Thanks for the nice work everyone!

What is missing to support mongoid 6 ?

dblock commented 7 years ago

@marceloboeira Just a passing build here! Feel free to take over.

dblock commented 7 years ago

Ignore me, just taking this over, https://github.com/mongoid/mongoid-slug/pull/234.

dblock commented 7 years ago

@marceloboeira notice that the gem as released works, there were no code changes

marceloboeira commented 7 years ago

@dblock yeap, I am using here, but I will sleep better knowing that the build is green for mongoid 6.x 👍