search

mongoid / mongoid-slug

Generates a URL slug/permalink based on fields in a Mongoid-based model.
https://github.com/mongoid/mongoid-slug
MIT License
492 stars 164 forks source link

rake task warnings #248

Closed ipatovanton closed 6 years ago

ipatovanton commented 6 years ago

I use ruby 2.5.0, rails 5.2 and mongoid 7.0

MacBook-Pro-Anton:tm ipatov$ rake mongoid_slug:set
/Users/ipatov/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/mongoid-slug-5.3.3/lib/tasks/mongoid_slug.rake:7: warning: constant ::TimeoutError is deprecated
/Users/ipatov/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/mongoid-slug-5.3.3/lib/tasks/mongoid_slug.rake:7: warning: constant ::Fixnum is deprecated
/Users/ipatov/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/mongoid-slug-5.3.3/lib/tasks/mongoid_slug.rake:7: warning: constant ::Bignum is deprecated
/Users/ipatov/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/mongoid-slug-5.3.3/lib/tasks/mongoid_slug.rake:7: warning: constant ::Data is deprecated
dblock commented 6 years ago

So these are warnings, the task actually succeeds, right?

ipatovanton commented 6 years ago

No, nothing happened after this

ipatovanton commented 6 years ago

after 10 minutes is completed

dblock commented 6 years ago

It could use some logging, feel free to PR both that and a fix for these warnings.

kailan commented 6 years ago

Resolved in https://github.com/mongoid/mongoid-slug/commit/f732b7aad79c82dacc6c41629a1001a30d042da8.