search

mono / CppSharp

Tools and libraries to glue C/C++ APIs to high-level languages
MIT License
3.15k stars 518 forks source link

Couldn't remove modules without translation units #1861

Closed HenrikAkseliValve closed 3 months ago

HenrikAkseliValve commented 3 months ago

I do not know I'm first to encounter this, however, loop that removes modules without translation units, could not have worked.

In C# Enumerator prohibits editing the collection so you cannot remove modules from options.Module while iterating options.Module. CppSharp_Enumeration_bug00 CppSharp_Enumeration_bug01

Chose RemoveAll for its simplicity. Not necessary optimal solution although it might be.

HenrikAkseliValve commented 3 months ago

@dotnet-policy-service agree

HenrikAkseliValve commented 3 months ago

Thank you. Fastest merge request I have ever requested. 👏

tritao commented 3 months ago

Thank you. Fastest merge request I have ever requested. 👏

Thanks for the contribution too.