search

mono / ngit

Automated jgit port to c#
261 stars 152 forks source link

TransportHttp.IsSmartHttp bug when charset is specified in header #12

Closed fealebenpae closed 13 years ago

fealebenpae commented 13 years ago

Fixed TransportHttp.IsSmartHttp to correctly handle content-header values containing a charset. See https://github.com/slluis/ngit/issues/10.

slluis commented 13 years ago

The IsSmartHttp issue is a bug in JGit, so it should be reported and fixed there (http://www.eclipse.org/jgit/support/). The fix for the HttpURLConnection issue is committed. Thanks!

alanmcgovern commented 12 years ago

I just committed a workaround for the issue. Technically the server is incorrect in including charset information and it is at fault, however it is trivial to work around the problem and it will not cause any regressions. Upstream do not seem like they are going to accept an equivalent patch, so there is no point in waiting for them to implement the workaround.