monome / maiden

web based editor and repl for norns
GNU General Public License v3.0
47 stars 33 forks source link

fix eslint and prettier errors #216

Closed midouest closed 2 years ago

midouest commented 2 years ago

I'm planning on tackling some of the "good first issue" issues in this repo. However, I noticed that I'm getting a lot of lint errors in VSCode, so I decided to run yarn lint --fix first. I did have to manually fix a few spots which I will call out with comments.

Thanks for considering these changes!

ngwese commented 2 years ago

Thanks for the PR! Fixing the lint and formatting stuff is long overdue. I’m trying to remember why we backed away from it in the early days.

I’ll try to review today or tomorrow in more detail!

ngwese commented 2 years ago

so so sorry for the delay in reviewing and merging. time has been in short supply and i prioritized a bunch of kernel work to support the 2022 shield hardware.