Manage layouts by nested elements

[maximehuran]

Based on https://github.com/monsieurbiz/SyliusRichEditorPlugin/pull/202 by @julien1619 😍

closes #172

Embedded elements

Use the row element and column element to build layouts.

Example in admin :

Each block layout is bordered to identify them.

Example in front :

Demo of the form :

https://github.com/monsieurbiz/SyliusRichEditorPlugin/assets/11380627/bcfc70b7-ec38-45d5-9464-8de96398fe47

[maximehuran]

I need to check why the copy / paste feature does not work anymore

[maximehuran]

This issue is not related to this PR. But I found a missing development in this one.

Children rich editors must use the same tags as their parent editor. This is done in https://github.com/monsieurbiz/SyliusRichEditorPlugin/pull/203/commits/a422238bffb98a67fd77160565681ee16f549d15

[maximehuran]

I made another PR for the paste issue

https://github.com/monsieurbiz/SyliusRichEditorPlugin/pull/204

[julien1619]

Good catch for the tags problem! I must admit I didn't use them. :) The problem you have with the paste issue does not seem related to this PR, so do you think you will be able to merge it soon?

[julien1619]

Is there anything missing to merge this PR?

[maximehuran]

For me it's ok ping @jacquesbh ?

[jacquesbh]

I just made some changes in the display in admin. Also I've updated the README for a better understanding. And rows are not side by side but below each other, and columns are side by side and not below each other, Maxime 🤭

[julien1619]

Thank you for the merge!

However, I must say that I'm a bit surprised by the last change that inverted Row and Column. In every layout system I worked with (flutter and bootstrap for example), it's named as follow:

• Row: Layout a list of widgets in the horizontal direction
• Column: Layout a list of widgets in the vertical direction

Can you fix it?

[jacquesbh]

That is exactly what we have.

--

Le mar. 5 sept. 2023, 19:57, Julien Blatecky @.***> a écrit :

Thank you for the merge!

However, I must say that I'm a bit surprised by the last change that inverted Row and Column. In every layout system I worked with (flutter and bootstrap for example), it's named as follow:

• Row: Layout a list of widgets in the horizontal direction
• Column: Layout a list of widgets in the vertical direction

Can you fix it?

— Reply to this email directly, view it on GitHub https://github.com/monsieurbiz/SyliusRichEditorPlugin/pull/203#issuecomment-1707060389, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGRT42SJEN65W5QQ2ITLZTXY5RZTANCNFSM6AAAAAA3YLSBKA . You are receiving this because you modified the open/close state.Message ID: @.***>

[julien1619]

I checked again and I'm pretty sure there is a misunderstanding.

The last commit describe the Row Layout Element as follows: each element will be displayed one below the other -> vertical

While in other layout systems, a Row Layout Element is: Layout a list of widgets in the horizontal direction -> horizontal

It seems reversed to me.

[jacquesbh]

Hum, maybe it's just a vocabulary issue.

Examples with UI Elements in each Layout:

Row Layout:

ELEMENT ELEMENT ELEMENT

Column Layout:

ELEMENT ELEMENT ELEMENT

In a Row Layout each element is a new row. In a Column Layout each element is a new column.

Seems correct to me, isn't it?

--

Le mer. 6 sept. 2023 à 12:31, Julien Blatecky @.***> a écrit :

I checked again and I'm pretty sure there is a misunderstanding.

The last commit describe the Row Layout Element as follows: each element will be displayed one below the other -> vertical

While in other layout systems, a Row Layout Element is: Layout a list of widgets in the horizontal direction -> horizontal

It seems reversed to me.

— Reply to this email directly, view it on GitHub https://github.com/monsieurbiz/SyliusRichEditorPlugin/pull/203#issuecomment-1708084644, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGRT44FODHN6DSFLROYN6LXZBGH5ANCNFSM6AAAAAA3YLSBKA . You are receiving this because you modified the open/close state.Message ID: @.***>