search

montoyo / mcef

Minecraft ChromiumEF (based on JCEF)
Other
191 stars 83 forks source link

java + mcef process won't shut down #5

Open pelikhan opened 9 years ago

pelikhan commented 9 years ago

The Minecraft project and MCEF helper process won't completely shutdown after use. Does the CEF runtime need to be notified that the process is shutting down?

montoyo commented 9 years ago

Interesting... I thought I fixed this bug with the 0.5 release... anyway, this never happend on my computer, so it's hard to fix it. Do you close Minecraft using the window's close button or Minecraft's quit button? Which version of java are you using? Thanks a lot for your contribution!

pelikhan commented 9 years ago

Closing the windows always, windows 8.1, Java latest.

Sent from Outlookhttp://taps.io/outlookmobile

On Wed, Apr 8, 2015 at 7:33 AM -0700, "Nicolas" notifications@github.com<mailto:notifications@github.com> wrote:

Interesting... I thought I fixed this bug with the 0.5 release... anyway, this never happend on my computer, so it's hard to fix it. Do you close Minecraft using the window's close button or Minecraft's quit button? Which version of java are you using? Thanks a lot for your contribution!

Reply to this email directly or view it on GitHubhttps://github.com/montoyo/mcef/issues/5#issuecomment-90934139.

vico93 commented 8 years ago

Confirmed ocourence here. A note: i CANT kill the java process using taskkill in cmd, only using task manager. I dont have the error right now, but i can reproduce to give a better report.

Version: 0.7 OS: Windows 8.1 (before), Windows 10 (now), both x64 Java: 8.45

BenjaminLawson commented 8 years ago

Probably a JCEF bug (possibly due to off screen rendering): https://bitbucket.org/chromiumembedded/java-cef/issues/152/windows-keeps-running-after-shutdown https://bitbucket.org/chromiumembedded/java-cef/issues/138/application-doesnt-terminate-after

Just wait for them to fix it. It doesn't occur on Mac & Linux.

derofim commented 6 years ago

hmm... really fixed version here, see src\main\java\net\montoyo\mcef

https://1drv.ms/u/s!AnTAt-3DzC4SgeotLgyXCu4Q0MltLA

removed ShutdownPatcher removed onStop onStart + PROXY.onShutdown(); in onMinecraftShutdown

used something else...

(also fixed some minor issues: with mouse coords e.t.c.)

derofim commented 6 years ago

also may help https://bitbucket.org/snippets/alancq/nKMak see shutdown(); at the end

montoyo commented 6 years ago

I'm starting to think this is due to some webpages opening new tabs behind the scenes. These tabs are not added to MCEF's browser ArrayList and thus are not closed when Minecraft shuts down. This results in the java process hanging.

spannerman79 commented 6 years ago

@montoyo on the last known working versions for 1.7.10 ( MCEF-1.7.10-0.6.jar & WebDisplays-0.11.jar ) even when using Youtubes WebTV URL ( http://youtube.com/tv ) it doesn't open a second tab and yet it doesn't get killed off when minecraft is closed down normally.

dsco01 commented 4 years ago

I know 1.7.10 is not supported at this time. I was trying to get the code to make the necessary edits to make sure it was able to close properly or if derofim can repost his working version. Can anyone help with that?