search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
58 stars 49 forks source link

Improvement: if an activity has no monologo, and you fiddle one in, you want no "nofilter" class for the img. #302

Open lucaboesch opened 1 year ago

lucaboesch commented 1 year ago

I'll admit that's an edge case but it is probably going to happen. To reproduce: install a plugin which has no monologo.svg, e.g. https://moodle.org/plugins/mod_capquiz . Optionally, fiddle 

        case FEATURE_MOD_PURPOSE:
            return MOD_PURPOSE_ASSESSMENT;

in in the lib.php capquiz_supports function.

Override the icon with the branding possibility, overriding it with the monologo.svg icon from https://github.com/bostelm/moodle-mod_scheduler maybe.

What you expect: A white icon on pink background. What actually happens: A black icon on pink background.

image image
abias commented 1 year ago

Hi Luca,

thank you for raising this issue. I see your point, but I am unsure if and how we can fix it properly in Boost Union, especially as your prerequisites are constructed and not a real life example.

I feel tempted to say that, if a plugin does define a purpose but does not ship with a monologo file, then it's broken.

However, if you have a proposal for a easy solution, then please do not hesitate to submit a PR.

PS: There might be an overlap with MDL-77105 which was integrated recently into Boost core and which also deals with tinting icons.

HsH-Wolf commented 4 months ago

Hi @lucaboesch

does this problem still exist, if you change the icons via the boost union setting "Activity icons"?

Best regards Yvonne