moodle-saml / auth

Moodle SAML Auth plugin
https://moodle.org/plugins/auth_saml
3 stars 21 forks source link

Remove special chars from generated admin-settings-name. #22

Closed phreaknerd closed 3 years ago

phreaknerd commented 5 years ago

We have to generate admin-setting-names that are compatible with moodle core otherwise they will throw an exception.

see moodle/lib/adminlib.php:1700

if (!preg_match('/^[a-zA-Z0-9_]+$/', $this->name)) { throw new moodle_exception('invalidadminsettingname', '', '', $name); }

pitbulk commented 3 years ago

Already covered by: https://github.com/moodle-saml/auth/commit/8a8e5e02a37c893ba4665b47e904f99eb32bcd35