moodleou / moodle-mod_oublog

Alternative blog module for Moodle 2 (including course blogs)
31 stars 27 forks source link

version.php file doesn't match release versions #127

Open thepurpleblob opened 1 year ago

thepurpleblob commented 1 year ago

The version.php file in Github hasn't been updated for two years and still shows version 3.9 (in both the 3.11 stable release and master). The downloaded version from the plugins page shows a much newer version number.

Effectively, this makes is impossible to test the master version as the version.php file says it's old code.

thebenkahn commented 1 year ago

I was just coming here to post this issue.

The master branch of repo is labeled as the 3.9 version contains code for the userfieldsapi that does not work in 3.10 and earlier

$plugin->version = 2020091401; $plugin->release = '3.9 r1'; and that is what we deployed to the site. This also matches the version string (2020091401) on the zip file for 3.9 on moodle.org.

When run on 3.10 and higher it causes an exception when accessing the activity

Exception - Class 'core_user\fields' not found
[More information about this error](https://docs.moodle.org/310/en/error/moodle/generalexceptionmessage)
×Debug info:
Error code: generalexceptionmessage
×Stack trace:
line 707 of /mod/oublog/locallib.php: Error thrown
line 241 of /mod/oublog/view.php: call to oublog_get_posts()

Since the newer branches use functionality that doesn't exist in 3.9/3.10, I think an update is needed for the "requires" field accordingly.

stopfstedt commented 1 year ago

i'm just getting hip to this issue as well. please put the source code of the latest release under version control here. thanks.