search

moodleou / moodle-mod_oublog

Alternative blog module for Moodle 2 (including course blogs)
31 stars 27 forks source link

PHP 8 fixes not on master #139

Closed micaherne closed 3 months ago

micaherne commented 3 months ago

The fixes to optional parameters coming before required ones in method signatures, mentioned in https://github.com/moodleou/moodle-mod_oublog/issues/126 don't seem to have made it onto master.

The commit is https://github.com/moodleou/moodle-mod_oublog/commit/9b3f0d343646a6bcf8394a01d712d6bb1ac2c7ce if you want to do a cherry pick.

(I know I'm making some assumptions here about your development process - particularly that master is the development branch that will end up as a Moodle 4.3 compatible version - but I don't know if this is valid. If not, please just ignore me 😄 )

micaherne commented 3 months ago

Sorry I should have mentioned that this is causing unit test errors with PHP 8.

micaherne commented 3 months ago

Apologies, it looks like my fork of the repo wasn't updating properly and this is actually nonsense!