Rework build script to rely on `dotnet` only

moodmosaic / Fare

Port of Java dk.brics.automaton and xeger, mostly used for generating strings that match a specific regular expression.

http://www.brics.dk/automaton/

MIT License

183 stars 43 forks source link

Rework build script to rely on `dotnet` only #43

Closed zvirja closed 6 years ago

zvirja commented 6 years ago

Fixes #42

@moodmosaic Now it should work fine without VS 😉

zvirja commented 6 years ago

I just set up the VM with Win 10 + .NET Core 1.1 SDK + .NET Core 2.1 SDK + .NET 452 SDK and tested it. Indeed, it fails with the mentioned error. It's caused by the fact we are targeting .NET 3.5 for the main library. If I change it to 452 it works fine.

I wasn't able to find .NET 3.5 SDK standalone or find the solution. Therefore, I could suggest either:

Install VS locally and enable .NET 3.5 dev kit (installer allows to do that)
Enable AppVeyor and use it for the build.
Stop targeting such an old frameworks and re-target to .NET 452 😅

Sorry, I spent a few hours, but don't see any other way. Would be happy to hear if you found 😉

moodmosaic commented 6 years ago

Thank you for all the hard work you’ve been putting in. It’s much appreciated.

I think it’s time to target a newer version of .NET, as you correctly wrote. — The reason this is targeting such an old .NET version is because I’d never had the need to change it, until now.

Imagine that when I ported all this from Java, .NET 3.x was the latest and greatest 😆

zvirja commented 6 years ago

Ok then. Giving that nothing else left from the build script perspective, I this PR can be merged. If you wish to migrate project to .NET 452, please fire a separate PR and release a new major version 😉

Let me know if you wish further actions on this PR from my side.

moodmosaic commented 6 years ago

Let me know if you wish further actions on this PR from my side.

No other actions needed.

💯

moodmosaic commented 6 years ago

FWIW, I might consider targeting net452 and netstandard2.0. Perhaps it's time to move on given the current constraints caused by the official tooling from Microsoft.