Add missing unit tests for passengers

[moonglum]

Add unit tests for the passengers. Please check off when done:

• [x] dotfile.rb
• [x] fonts.rb
• [x] git_repo.rb
• [x] homebrew.rb
• [x] npm.rb
• [x] python.rb
• [x] rbenv.rb
• [x] rvm.rb
• [x] vundle.rb

[moonglum]

Could you add the unit tests for your Font passenger @bitboxer? Then we're done with this ticket!

[bitboxer]

Will do.

[moonglum]

Cool :smile:

[bitboxer]

Arg...I tried for half an hour to understand how test_construct rspec tries to do it's stuff, but I failed. I will now use normal tempdir stuff :disappointed:

[moonglum]

Why do you need that? Don't you want to isolation test it?

[bitboxer]

There are two options:

a) mock everything file related or b) create a temp directory with fonts in it and let the stuff work on that

I prefer the later because you have to mock less. I don't like tests that mock too much. The executor mocking is not what I like to do. Feels like writing the implementation again. If I change one line in the tested code, the expect executor stuff is falling apart.

[moonglum]

Ok, let’s discuss testing in general after 0.3 :smile_cat:

[bitboxer]

Jep. Would love some insights on that!