search

moosetechnology / Moose

MOOSE - Platform for software and data analysis.
https://moosetechnology.github.io/moose-wiki
MIT License
136 stars 34 forks source link

Roassal does not display edges when the source is not visible #987

Closed seandenigris closed 9 years ago

seandenigris commented 9 years ago

Originally reported on Google Code with ID 987

Try this:

view nodes: { 1 . 2 }.
view edgeFromAssociation: 2->1.
view horizontalLineLayout horizontalGap: 1000.

I think it is easy to fix, but at the same time it is really annoying, so I mark it
as critical :)

Reported by tudor@tudorgirba.com on 2013-10-15 15:09:40

seandenigris commented 9 years ago 
Hmm. This problem seems to appear only when Roassal is embedded in Glamour. Try this:

view := ROMondrianViewBuilder new.
view nodes: { 1 . 2 }.
view edgeFromAssociation: 2->1.
view horizontalLineLayout horizontalGap: 3000.
view open.

vs.

view := ROMondrianViewBuilder new.
view nodes: { 1 . 2 }.
view edgeFromAssociation: 2->1.
view horizontalLineLayout horizontalGap: 3000.
view openWithStatusbar.

Reported by tudor@tudorgirba.com on 2013-10-19 01:41:14

seandenigris commented 9 years ago 
Fixed in 1.456. There was indeed a bug in the code. 
Now, there is the following:

- A node is rendered if its bounds intersect with the bounds of the camera
- An edge is rendered if at least one of its extremity has its bounds intersect with
the camera

As a consequence, an edge that has no extremity on screen is not displayed. Even if
the line "go through" the camera bounds. Naturally, this is something that is easy
to change. We can provide particular strategy to define what makes an edge visible
or not.

Reported by alexandre.bergel on 2013-10-20 13:42:01

seandenigris commented 9 years ago 
The edge should be rendered if it crosses the camera, even if the nodes are not in the
camera. It is confusing otherwise.

I am reopening this issue.

Reported by tudor@tudorgirba.com on 2013-12-19 05:16:33

seandenigris commented 9 years ago 
It's fixed now.

Reported by tudor@tudorgirba.com on 2014-03-02 06:32:14