mooz / js2-mode

Improved JavaScript editing mode for GNU Emacs
GNU General Public License v3.0
1.33k stars 186 forks source link

Remove the correct hook in js2-minor-mode-exit #589

Closed pkryger closed 2 years ago

pkryger commented 2 years ago

The js2-minor-mode-enter adds js2-minor-mode-edit to after-change-functions. Contrary the js2-minor-mode-exit removes js2-mode-edit which had not been added to the list.

Without that, after enabling js2-minor-mode the js-lint remains enabled even when the mode exits.

I decided to go straight for a PR, as the issue looks like an obvious mistake, at first glance. Should that be not the case, apologies, for a naïve approach.

dgutov commented 2 years ago

Thanks!