search

mopidy / mopidy-local-sqlite

DEPRECATED (Mopidy SQLite local library extension)
https://mopidy.com
Apache License 2.0
30 stars 10 forks source link

Browse by addition date #40

Closed freddez closed 9 years ago

freddez commented 9 years ago

Hello, I've found this addition useful, don't you think ? Fred.

tkem commented 9 years ago

First of all, thanks for sharing! I really appreciate that. Nevertheless, I have a few issues with this:

  1. I thought about something like this myself a while ago (#35), but I'm still not sure if this really fits in with the whole "browsing" concept, or if it wouldn't be served better as a playlist, as originally suggested in mopidy/mopidy#562.
  2. IMHO, it does not do what it's advertised to do. If I browse "Date Added", I expect to be able to browse all dates I added tracks to the local library, similar to release years. So, as I said above, maybe this really would be better served as a "dynamic" playlist.
  3. Mopidy-Local-SQLite tries hard to avoid any hardcoded limits, magic numbers or English string constants (to be prepared for I18N some time in the hopefully not far too distant future). So if you can come up with something more flexible that fits with the URI scheme and can actually be configured via directiories, I'll be glad to give it another look. Like, browsing "last week", "last month" and "last year" may seem sensible to you, but what if I'd like to see last fortnight's additions?
freddez commented 9 years ago

Hello Thomas, I understand your points, but :

  1. Shure, a dynamic playlist implementation would be better, but it is not available now, and the functionality to find easily what albums you have added last week or month seems very important for anyone who have a big library. So why not add such a functionnality ? If dynamic playlist comes, you can drop that solution.
  2. Release year could be accurate ("I want to play 70's funk" (oops, relase decade here)), but finding what I have added in 2009 ?
  3. Again, there is no i18n for the moment in mopidy package, is it a reason to forbid english strings in the source ? If one day mopidy project adds i18n, tagging your source will not be too long.

I totaly agree with you with dynamic playlists, and even if it would be so nice to add a dynamic playlist directly to the interface and find it in the playlist section, I think the simpler, or best starting solution would be to accept logical expressions in directories configuration, like : 70's Funk local:directory?genreicontains=funk&release_date__gte=1970&release_datelt=1980 don't you think ?

On Tue, Dec 2, 2014 at 8:11 PM, Thomas Kemmer notifications@github.com wrote:

First of all, thanks for sharing! I really appreciate that. Nevertheless, I have a few issues with this:

  1. I thought about something like this myself a while ago (#35 https://github.com/tkem/mopidy-local-sqlite/issues/35), but I'm still not sure if this really fits in with the whole "browsing" concept, or if it wouldn't be served better as a playlist, as originally suggested in mopidy/mopidy#562 https://github.com/mopidy/mopidy/issues/562.
  2. IMHO, it does not do what it's advertised to do. If I browse "Date Added", I expect to be able to browse all dates I added tracks to the local library, similar to release years. So, as I said above, maybe this really would be better served as a "dynamic" playlist.
  3. Mopidy-Local-SQLite tries hard to avoid any hardcoded limits, magic numbers or English string constants (to be prepared for I18N some time in the hopefully not far too distant future). So if you can come up with something more flexible that fits with the URI scheme and can actually be configured via directiories, I'll be glad to give it another look. Like, browsing "last week", "last month" and "last year" may seem sensible to you, but what if I'd like to see last fortnight's additions?

— Reply to this email directly or view it on GitHub https://github.com/tkem/mopidy-local-sqlite/pull/40#issuecomment-65286017 .

Frédéric de Zorzi - PimenTech http://www.pimentech.fr 7bis, rue de LESSEPS - 75020 PARIS Tel : 09 50 75 93 39 / +33663180800

tkem commented 9 years ago

Hey, thanks for responding (most people would hvae been p*****ed off and never talk to me again)! Please, don't get me wrong -- I'm thankful for what you did, and your code as far as I checked so far is class A. I just have to consider maintenance and the rather unpredictable ways Mopidy as a whole is going to in the future,

So...

  1. I guess I got your point. Come up with a configurable solution (like a max-age query parameter), and I'll think about it. Hard-coded intervals are a no-go, sorry ;-)
  2. Maybe you got me wrong on this one: if it says "Date Added", I expect to see a list of "2014-12-01", "2014-11-20", "2014-09-16", etc., dates I added local files.
  3. Yes, there's a reason for forbidding English strings in source code. Ask anybody who had to I18N an existing application. Another no-go, sorry-
tkem commented 9 years ago

I finally came up with something close to your original solution that I guess I can live with. If you have some time, please check out 9f840b0d345c58973525eb2ad91153de4400022c, and tell me if it meets your needs.

freddez commented 9 years ago

Sorry, didn't have time to check yet, thanks for the feature

On Fri, Dec 12, 2014 at 8:13 AM, Thomas Kemmer notifications@github.com wrote:

Closed #40 https://github.com/tkem/mopidy-local-sqlite/pull/40.

— Reply to this email directly or view it on GitHub https://github.com/tkem/mopidy-local-sqlite/pull/40#event-206621893.

Frédéric de Zorzi - PimenTech http://www.pimentech.fr 7bis, rue de LESSEPS - 75020 PARIS Tel : 09 50 75 93 39 / +33663180800

tkem commented 9 years ago

That's allright, thanks for your inspiration and stubborn insistence ;-)