mopidy / mopidy-scrobbler

Mopidy extension for scrobbling played tracks to Last.fm
https://mopidy.com/ext/scrobbler/
Apache License 2.0
66 stars 14 forks source link

Scrobble to Libre.fm & keep Last.fm stats clean by scrobbling only the first returned (album) artist. #18

Open 0nse opened 8 years ago

0nse commented 8 years ago

Update: Support Libre.fm. If a session key does not exist yet, the user is prompted to do create one using their Web browser.

Please note that changes to the configuration schema had to be made. These are explained in the README.

Everything below is about scrobbling the primary artist (which was the original pull request).


Current problem: If one plays a track by multiple artists, these are scrobbled by concatenating them using a semicolon. For one, ID3v2.3 recommends using slashes. Moreover, this creates a lot of new pages on Last.fm for artists that collaborate with others, when using Spotify. Additional information about this problem can be found in mopidy/mopidy#1389.

This pull request:

Effects:

Drawbacks:


In the end, this pull request remains a workaround for mopidy/mopidy#1389. Personally, I prefer this solution but you might want to consider creating a dedicated branch instead of merging it onto master.

marsjaninzmarsa commented 7 years ago

Why not follow native Spotify scrobbler behavior, converting additional artists to feats in name?

0nse commented 7 years ago

I hadn't been aware of the behaviour you are describing. In fact, when I implemented this, I remember the official Spotify app fucking up scrobbles similarly.

Nowadays I'm hardly ever using the mopidy-scrobbler anymore. You are welcome to improve on this PR though.