search

moqui / mantle-usl

Mantle Universal Service Library
http://www.moqui.org/mantle.html
Other
29 stars 61 forks source link

do not create a shipment for an order with a non-shippable item #178

Closed hansbak closed 2 years ago

hansbak commented 2 years ago

a shipment is created from an order even if the orderitem product has a type of assetUsage.

jonesde commented 2 years ago

This changes the logic so that if an order has items with products of any of the given types ('PtAsset', 'PtDigitalAsset', 'PtAssetUse', 'PtPickAssembly') then it does not create a shipment.

Based on the comment on the PR it seems you want to exclude 'PtAssetUse', which could be discussed, but these are the 4 primary product types that NEED a shipment.

hansbak commented 2 years ago

Thanks for your quick comment,

looking into it a bit further and added a new productType PtFixedAssetUse here locally to show the rental of hotel rooms which do not need a shipment.

jonesde commented 2 years ago

Yes, the general idea with PtAssetUse is that it is for things that would be shipped (portable assets), and sounds like you are working on non-portable assets like hotel rooms or house or the like. A different product type would be a good idea for that.