search

moqui / mantle-usl

Mantle Universal Service Library
http://www.moqui.org/mantle.html
Other
28 stars 60 forks source link

Add task comment to avoid null on subject and body fields #192

Closed acetousk closed 1 year ago

acetousk commented 1 year ago

This fixes this happening: Screencast from 10-14-2022 12:15:39 PM.webm

And makes it now look like this: Screencast from 10-14-2022 12:16:36 PM.webm

jonesde commented 1 year ago

Interesting issue... and yes the 'null' there is ugly. My first thought on it is that given that the issue/ugliness is in the display, that is the better place to address it. Along with there, there is some value in a null in the DB if no subject/etc is specified, or rather the data is cleaner if this is handled in presentation rather than with defaults in the service that writes data.

jonesde commented 1 year ago

Unless there is a significant reason to do this it is best to avoid... ie handle nulls on display rather than using empty strings (or strings with a single space).