search

moratodpg / imp_marl

IMP-MARL: a Suite of Environments for Large-scale Infrastructure Management Planning via MARL
Apache License 2.0
35 stars 5 forks source link

lint #72

Closed PaLeroy closed 10 months ago

PaLeroy commented 11 months ago

Glad Black makes almost everything automatically 😆

moratodpg commented 11 months ago

This looks very clean and nice now! Great job :) Shall we conduct a series of tests to ensure everything is working fine?

PaLeroy commented 11 months ago

Yeah this is not a bad idea 😄 Especially because if we wanna go JAX, we will have to write and figure out some tests anyway.

moratodpg commented 10 months ago

It seems we might have to re-run this one before merging?

PaLeroy commented 10 months ago

re runned. We may need to go over the files to be sure but it should be ok :D

PaLeroy commented 10 months ago

Tests are ok btw. I went over stuff again and we can merge! :D

moratodpg commented 10 months ago

Outstanding! Great work once again, Pascal! Let's merge it. I am looking forward to getting started with our next steps.