moratodpg / imp_marl

IMP-MARL: a Suite of Environments for Large-scale Infrastructure Management Planning via MARL
Apache License 2.0
35 stars 5 forks source link

Tests #73

Closed PaLeroy closed 10 months ago

PaLeroy commented 10 months ago

First tests on struct_env to start. Had to change the name of the folder imp_env for docstring compatibility.

Tell me if the tests suit you and if you can think of something else, then we'll proceed quickly.

PaLeroy commented 10 months ago

We have now pytest and doctest, the latter will help for documentation I believe!

PaLeroy commented 10 months ago

Pytest tracks files starting with "test", so I modified it because test_with_pymarl is not a test. Afterwards, I added this pytest config file, which may have solved the issue, but I did not try. Why is it confusing anyway? Another possibility is to go with pymarl_train and pymarl_test.

For the test folder, I guess everyone just names it "test", I honestly do not care too much.

Would you have any thoughts on the tests themselves?

PaLeroy commented 10 months ago

Maybe we accept this PR to have a clean sheet for reorganisation?

moratodpg commented 10 months ago

Agreed :)