Improve the DLL search pattern

morefigs / pymba

Python wrapper for Allied Vision's Vimba C API

MIT License

105 stars 84 forks source link

Improve the DLL search pattern #127

Open mabl opened 4 years ago

mabl commented 4 years ago

This should make it discover newer versions such as the recently released Vimba 4.0, too.

morefigs commented 4 years ago

Thanks, much nicer! My only hesitation is that this requires Python 3.4, which may cut off some users.

mabl commented 4 years ago

Yes, I specifically checked for the patlib library availability. But Python 3.4 is already end of life. Even Python 3.5 will be EOL in september.

mabl commented 4 years ago

The more critical thing, I just realized would be the format strings I used. That is python 3.6. Feel free to use ore modify this code as you like :-) I just ran across it when the current pymba version did not like vimba 4.

morefigs commented 4 years ago

Fair point on v3.4. Yes, the f-strings are still an issue for some users, if you can remove that I'll merge ;)