chore(android): add support for AGP 8

morenoh149 / react-native-contacts

React Native Contacts

MIT License

1.64k stars 560 forks source link

chore(android): add support for AGP 8 #717

Closed AndreiCalazans closed 1 year ago

AndreiCalazans commented 1 year ago

Change to support AGP 8 as mentioned here: https://github.com/react-native-community/discussions-and-proposals/issues/671

This does not remove package attribute from AndroidManifest to not lose compatibility with AGP < 8 (React Native < 0.71 versions).

I don't think it's worth maintaining logic to remove that attribute contitionally since it will only cause a warning to users on AGP 8 and above.

mikehardy commented 10 months ago

Would be great to publish this one :-) - I almost proposed the same PR 😆 - working around this now with patch-package, react-native 0.73 is in release candidate phase now and will release soon, it includes android gradle plugin 8 so this will be required shortly for up to date apps

morenoh149 commented 10 months ago

@mikehardy published

mikehardy commented 10 months ago

Fantastic! Thanks, and thanks for maintaining this library, I appreciate it