Closed mattssca closed 1 year ago
This build check should now pass with no warnings, as well. Let's wait and see...
Thanks, Adam! I think this looks good - but are we gonna do with #191 now?
I think we could just delete that RP since everything in it is also included in this PR.
ok! Will that brunch have merge conflicts once this one is merged?
Do you mean, if the original PR (rmorin-dev) will have merge conflicts once this is merged?
Right, yes.
I don't know, possibly. But it wouldn't matter, right?
Pull Request Checklists
Important: When opening a pull request, keep only the applicable checklist and delete all other sections.
Checklist for all PRs
Required
[ ] I tested the new code for my use case (please provide a reproducible example of how you tested the new functionality)
[ ] I ensured all dplyr functions that commonly conflict with other packages are fully qualified.
This can be checked and addressed by running
check_functions.pl
and responding to the prompts. Test your code after you do this.[ ] I generated the documentation and checked for errors relating to the new function (e.g.
devtools::document()
) and addedNAMESPACE
and all other modified files in the root directory and underman
.[ ] I have rebuilt the site with
pkgdown::build_site(lazy = TRUE)
to reflect any updated package documentation.Optional but preferred with PRs
Checklist for New Functions
Required
[ ] I documented my function using ROxygen style.)
[ ] Adequate function documentation (see new-function documentation template for more info)
Example:
import
statement.Example:
Checklist for changes to existing code
[ ] I added/removed arguments to a function and updated documentation for all changed/new arguments
[ ] I tested the new code for compatibility with existing functionality in the Master branch (please provide a reprex of how you tested the original functionality)