search

morpho-org / morpho-optimizers

Core contracts of Morpho V1 Optimizers.
https://app.morpho.org
GNU Affero General Public License v3.0
137 stars 22 forks source link

Revert aave-v2 supply/borrow paused guards #1628

Closed Rubilmax closed 1 year ago

MerlinEgalite commented 1 year ago

@pakim249CAL to link to the PR on the right side of the PR

MathisGD commented 1 year ago

Can someone provide a quick description of why we are going back please ? I was not able to follow the discussion yesterday.

pakim249CAL commented 1 year ago

A few reasons given:

  1. No amount of checks will be sufficient, and we should be proactive about pausing before the underlying pool does.
  2. Hardcoding this can actually reduce flexibility in Morpho's pausing discretion since one action on Morpho can actually constitute multiple types of interactions with the pool.
  3. Some of the checks are gas intensive as information from the pool needs to be fetched.
MathisGD commented 1 year ago

Thanks !

(1.) notably makes a lot of sense