search

morpho-org / pre-liquidation

Other
3 stars 1 forks source link

change contract's name #34

Closed MathisGD closed 1 month ago

MathisGD commented 2 months ago 
          What about changing the name of the contract?

_Originally posted by @colin-morpho in https://github.com/morpho-org/pre-liquidation/pull/32#discussion_r1777207778_

peyha commented 2 months ago

I don't think it's worth changing the name of the contract at this point. The current version should handle necessary pre-liquidation use-cases

MathisGD commented 2 months ago

The issue stays open anyway: https://morpholabs.slack.com/archives/C02NE4SAE4B/p1727354254886229

peyha commented 2 months ago

The issue stays open anyway: https://morpholabs.slack.com/archives/C02NE4SAE4B/p1727354254886229

From this discussion, I feel like we should facilitate the end-user understanding and switch to either SoftLiquidation or LinearSoftLiquidation

colin-morpho commented 2 months ago

Which discussion @peyha ?

peyha commented 2 months ago

The one quoted by Mathis just above, just updated my message

colin-morpho commented 2 months ago

Thanks for adding the quote :) !

MathisGD commented 1 month ago

Should we style rename just the contract LinearPreLiquidation?

QGarchery commented 1 month ago

Should we style rename just the contract LinearPreLiquidation?

I think we can keep it like that. At worst we add more specification to future contracts (e.g QuadraticPreLiquidation)