search

morpho-org / pre-liquidation

Other
3 stars 1 forks source link

preLiquidationOracle Documentation #51

Closed Jean-Grimal closed 1 month ago

Jean-Grimal commented 2 months ago

https://github.com/morpho-org/pre-liquidation/blob/01c6faf81237a391bae4a9305cf4552719820d57/src/interfaces/IPreLiquidation.sol#L12

I’d add more documentation on what the preLiquidationOracle is supposed to be.
From what I understand, it can be a different oracle from the market’s one, to be able to price the collateral asset in a different (maybe more precise way?)
But it also could be the market’s oracle right ?

QGarchery commented 1 month ago

I agree that the documentation could be improved. It should be the market oracle most of the time, but it's there to enable the use case of OEV. There is no question of being more precise though (not sure what that means)

peyha commented 1 month ago

Good catch, I'll add it to the Readme. We could also add the oracle interface to the repo (right now we import it from morpho blue) to be clearer

peyha commented 1 month ago

The main use-case for this parameter is to use an OEV oracle such as Oval or API3

peyha commented 1 month ago

Done in #65