search

morpho-org / pre-liquidation

Other
3 stars 1 forks source link

improve constructor readability #70

Closed MathisGD closed 1 month ago

MathisGD commented 1 month ago

Proposition, as an alternative to #50 and #63.

Tests are breaking because of #69, also fixed by #74

QGarchery commented 1 month ago

Not much easier to read for me. I applied it to https://github.com/morpho-org/pre-liquidation/pull/50 though, I still find https://github.com/morpho-org/pre-liquidation/pull/50 simpler to understand.

The part that is easier to read (for me) is the natspec, not necessarily that all comparisons are in the same direction

peyha commented 1 month ago

Agree, this is way nicer

peyha commented 1 month ago

approving once conflict is solved

MathisGD commented 1 month ago

Just merged main after #74 has been merged